/api/Class/v1 bug on URI of external Properties

[c-mellueh]

Describe the bug
When Requesting a Class withIncludeClassProperties = Truethe URI of ClassProperties that reference external Properties is wrong

To Reproduce
Steps to reproduce the behavior:

1. request

curl -X "GET" ^
  "https://api.bsdd.buildingsmart.org/api/Class/v1?Uri=https%3A%2F%2Fidentifier.buildingsmart.org%2Furi%2Fhw%2Fsom%2F0.2.2%2Fclass%2FAlarm&IncludeClassProperties=true" ^
  -H "accept: text/plain"

2. look at result["classProperties"][8]["uri"]

>>> from bsdd import Client
>>> client = Client()
>>> class_uri = 'https://identifier.buildingsmart.org/uri/hw/som/0.2.2/class/Alarm'
>>> result = client.get_class(
...     class_uri,
...     include_class_properties=True,
...     include_class_relations=False,
...     include_reverse_relations=False,
... )
>>> print(result["classProperties"][8]["uri"])
https://identifier.buildingsmart.org/uri/hw/som/0.2.2/class/Alarm/prop/Pset_AlarmTypeCommon/uri/buildingsmart/ifc/4.3/prop/AlarmCondition

Expected behavior
the URI should be 'https://identifier.buildingsmart.org/uri/hw/som/0.2.2/class/Alarm/prop/Pset_AlarmTypeCommon/AlarmCondition'
instead, parts of the URI of the IFC Property are added

[Baars-IT]

Hi c-mellueh,

Actually, the URI returned is as we intended it to be, as "AlarmCondition" is not a property of the hw/som/0.2.2 dictionary. It is an IFC 4.3 property.
Suppose the class Alarm refers to two "AlarmCondition" properties, each from different dictionaries? That is a valid situation.
If we would make the URI as you suggested, there would be 2 identical URIs of different class properties. (and that is not valid)

So, not sure if/how we can solve this.

[c-mellueh]

@Baars-IT Ah ok i get it. Then in my opinion the identifier.buildingsmart.org server should at least be able to resolve the created URL (https://identifier.buildingsmart.org/uri/hw/som/0.2.2/class/Alarm/prop/Pset_AlarmTypeCommon/uri/buildingsmart/ifc/4.3/prop/AlarmCondition
) to show the Property