Context
PR #237 added schema version validation to registry responses, but the SchemaVersionTooNew error path for parse_search_index and load_pack_metadata can only be tested with a mock HTTP server (the methods are private on GitHubRegistry). Unit tests cover deserialization and the version comparison logic, but no integration test exercises the full error path through the HTTP layer.
Proposal
Add a wiremock-based integration test that:
- Serves an
index.json with schema_version: 99
- Verifies
weave search returns the SchemaVersionTooNew error
- Serves a
packs/test.json with schema_version: 99
- Verifies
weave install test returns the SchemaVersionTooNew error
Acceptance criteria
Context
PR #237 added schema version validation to registry responses, but the
SchemaVersionTooNewerror path forparse_search_indexandload_pack_metadatacan only be tested with a mock HTTP server (the methods are private onGitHubRegistry). Unit tests cover deserialization and the version comparison logic, but no integration test exercises the full error path through the HTTP layer.Proposal
Add a wiremock-based integration test that:
index.jsonwithschema_version: 99weave searchreturns theSchemaVersionTooNewerrorpacks/test.jsonwithschema_version: 99weave install testreturns theSchemaVersionTooNewerrorAcceptance criteria
index.jsonandpacks/{name}.jsonpaths