SSR

[nesvet]

Hi, @jerairrest! Awesome fork, thank you!

But it still has problems with SSR :-/ What about to switch to @hdngr's fork of domkit?

[jerairrest]

I shall take a looksie. We're looking at maybe switching to emotion and using css animations in comparison to domkit in a attempt to make the modal more responsive and easier to work with. How does that sound to you?

[nesvet]

@jerairrest, sounds great!

[jerairrest]

@nesvet I'm was going to implement @hdngr domkit for a quick win but I can't seem to find it on NPM. Am I blind or can you point me to the repo? If not I can always pull it in through a custom repo.

Let me know!

Jer

[hdngr]

npm install —save https://github.com/hdngr/domkit or npm install —save domkit@https://github.com/hdngr/domkit. I think. On mobile but can remember completely ;-)

[jerairrest]

@hdngr thanks!!!!

[jerairrest]

@nesvet can you please verify https://github.com/jerairrest/reboron/tree/bugfix-update-domkit works with SSR?

[nesvet]

@jerairrest it was installed without src directory or am I doing something wrong? :-/

I used git://github.com/jerairrest/reboron.git#bugfix-update-domkit url to install :-/

[jerairrest]

Sorry! I forgot to commit the built files. Please try again.

[nesvet]

@jerairrest it works!

[nesvet]

One important thing: it hides it's props.children markup until it will be .show()'n. So one of the goals of SSR is missed: web-crawlers can't grab it's content :-/

[jerairrest]

is there a demo of this somewhere so we can play around with this functionality?

[nesvet]

@jerairrest oh, you need React SSR boilerplate? All you need to do is to put props.children directly to DOM (hidden) and then, on .show() show it (not mounting and unmounting). In this case SSR will work well.