Skip to content

chore: harden verdict panel= parsing + fix stale README test count (137 vs 450) #111

Description

@jakecelentano

Scope

Two small hardening/hygiene items in the review poller area:

  1. panel= parse fragility. _PANEL_RE (lib/tms/review_poll.py:206, panel=(.+?)(?=\s+\w+=|$)) assumes the panel value is terminal or followed by another key= token. A verdict line whose panel value is followed by a bare non-key= word (or contains stray spaces) over-captures into the panel field. Replace with a tokenizer or tighten the lookahead, with regression tests for malformed-but-plausible verdict lines.

  2. README test-count drift. README.md:161 claims "137 tests, ~0.5s"; the suite collects 450. Update, or better, drop the hardcoded count so it cannot drift again.

Acceptance criteria

  • Malformed panel values covered by regression tests (trailing word, embedded spaces, empty panel)
  • parse_verdict_line behavior on those inputs documented in the docstring
  • README test claim corrected or made count-free

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions