build_context renders unresolved forward references as [[None]] instead of the stored target name

[phernandez]

Summary

build_context with output_format="text" renders unresolved forward references as [[None]]:

### Relations
- see_also [[None]]
- see_also [[None]]
- links_to [[None]]
- see_also [[bm-note(5)]]

The knowledge format explicitly encourages forward references ("targets need not exist yet"), so any growing knowledge base hits this. The original target name is stored and available — the formatter just doesn't use it.

Reproduction

Against v0.21.6 cloud (also present in main @ 650f88a):

1. write_note a note containing relations to not-yet-existing targets, e.g. - see_also [[edit-note(3)]]
2. build_context(url="<that-note>", output_format="text")
3. Relations section shows - see_also [[None]] for every unresolved target

Meanwhile schema_validate on the same note correctly reports see_also values ["edit-note(3)", ...] — the data is intact, only the context rendering loses it.

Root cause

• models/knowledge.py:296 — Relation.to_name stores the literal forward-reference target text
• services/context_service.py (recursive CTE, ~line 458) — relation rows embed to_name only inside the composite title (r.relation_type || ': ' || r.to_name); to_id is NULL for unresolved relations and to_name is not selected as its own column
• api/v2/utils.py:134 — to_title = entity_title_lookup.get(item.to_id) if item.to_id else None → RelationSummary.to_entity = None
• mcp/tools/build_context.py:57 — f"- {rel.relation_type} [[{rel.to_entity}]]" → [[None]]

JSON output has the same gap: to_entity: null with no field carrying the forward-reference name (the consumer can only recover it by parsing the relation permalink).

Expected

### Relations
- see_also [[edit-note(3)]]   ← the name the relation was written with

Suggested fix

Select r.to_name as a proper column in the context CTE relation rows, add it to ContextResultRow and RelationSummary (additive, optional), and have the text formatter fall back: rel.to_entity or rel.to_name. This also fixes the JSON consumers' gap.

Context

Found during live verification for #952 (manual pages) — surfaced on the very first build_context traversal of the manual's SEE ALSO graph, since a new manual is mostly forward references. Fix with regression test planned on the #952 worktree branch.

[claude]

Claude finished @phernandez's task in 8m 20s —— View job

---

Triage & Fix: Forward References Rendered as [[None]]

Type: Bug | Priority: Medium | Component: MCP tools | Complexity: Medium

• Analyze issue and gather context
• Read relevant source files
• Fix CTEs in context_service.py to select to_name as proper column (both SQLite and PostgreSQL)
• Update ContextResultRow dataclass to include to_name: Optional[str]
• Update RelationSummary schema to include to_name: Optional[str]
• Fix api/v2/utils.py to populate to_name in RelationSummary
• Fix build_context.py text formatter: rel.to_entity or rel.to_name
• Write regression test
• Commit changes (2ee7e02)
• Push to remote — blocked (workflow has contents: read only, not contents: write)

---

Root Cause Confirmed

As described in the issue. The CTEs selected to_name only inside the composite title string (r.relation_type || ': ' || r.to_name) but never as a standalone column. This left ContextResultRow.to_name = None → RelationSummary.to_entity = None → text formatter rendered [[None]].

Changes Made (commit 2ee7e02 on claude/issue-955-20260611-0525)

src/basic_memory/services/context_service.py

• ContextResultRow: added to_name: Optional[str] = None
• SQLite CTE: r.to_name as to_name in relation branch, NULL as to_name in base case and entity branch; to_name added to final SELECT DISTINCT and GROUP BY
• PostgreSQL CTE: same — CAST(NULL AS TEXT) as to_name in base case; CASE WHEN step_type = 1 THEN r.to_name ELSE CAST(NULL AS TEXT) END as to_name in recursive step
• Row parser: to_name=row.to_name

src/basic_memory/schemas/memory.py — to_name: Optional[str] = None on RelationSummary

src/basic_memory/api/v2/utils.py — to_name=item.to_name in RelationSummary(...) constructor

src/basic_memory/mcp/tools/build_context.py — f"- {rel.relation_type} [[{rel.to_entity or rel.to_name}]]"

tests/mcp/test_tool_build_context.py — test_build_context_forward_references_render_target_name: writes a note with two unresolved forward-reference relations; asserts text output contains no [[None]] and JSON output has to_name populated for unresolved relations

Why push failed

The .github/workflows/claude.yml has contents: read — the action can't push branches. To resolve: add contents: write to the workflow's permissions block, or configure a PAT/app token with push access as CLAUDE_CODE_OAUTH_TOKEN/github_token.

[phernandez]

Fixed in #981 (commit 1ad3a35, on main). to_name is now selected as a standalone column in both context CTEs (SQLite + Postgres), threaded through ContextResultRow / SearchIndexRow / RelationSummary (additive), and the text formatter falls back to_entity or to_name — forward references render by their stored name instead of [[None]]. Regression tests in tests/services/test_context_service.py (run on both backends) and tests/mcp/test_tool_build_context.py.

The PR body's comma-separated "Fixes" list only auto-closed the first issue (#954) — closing manually.