Updates from amirreza-sf80

[moritz89]

@amirreza-sf80 just added quite a few updates to the base https://github.com/mariocesar/django-ltree/ library here:

https://github.com/amirreza-sf80/django-ltree/

Would it be interesting to "upstream" those changes to your library as it seems to be the most actively maintained fork at the moment?

[amirreza-sf80]

hmm
it's been a while
If i find the time I'll see if i can make this backwards compatible

tho ideas are appreciated 🙌

[baseplate-admin]

Hi @amirreza-sf80,

I will work on porting the changes (i currently am engaged with academic studies, i will get a 18 day holiday in about 14 days).

Could you please list the changes you made to your fork? I will gladly see how these might be ported to django-ltree-2

[baseplate-admin]

Also @amirreza-sf80, Would you be willing to be added to this repository as a collaborator?

[amirreza-sf80]

hi 👋
mariocesar/django-ltree#38 I've listed the changes here

I'm ok with being a collaborater, also ok with not being one, as you see fit 👍

I'm probably able to move the changes here, but let me know if you want them in separate PRs or just one, also if you want to keep backwards compatibility

[baseplate-admin]

I'm ok with being a collaborater, also ok with not being one, as you see fit 👍

I added you as a collaborator, welcome aboard ⛵(please let me know if you want pypi membership too)

_{repository can automatically upload to pypi}

---

I'm probably able to move the changes here, but let me know if you want them in separate PRs or just one,

I am okay with either.

---

if you want to keep backwards compatibility

yes please, the only part that is different from django-ltree is:

django-ltree-2/src/django_ltree/managers.py

Lines 24 to 45 in 399d54f

	def create_child(
	self, parent: "TreeModel" = None, label: str = None, **kwargs
	) -> TreeQuerySet["TreeModel"]:
	"""Creates a tree child with or without parent"""
	prefix = parent.path if parent else None
	"""If a label is not provided, we generate a new one, else we use it as suffix"""
	if label is None:
	paths_in_use = parent.children() if parent else self.roots()
	path_generator = PathGenerator(
	prefix,
	skip=paths_in_use.values_list("path", flat=True),
	)
	path = next(path_generator)
	else:
	if prefix is None:
	path = label
	else:
	path = str(prefix) + "." + label
	kwargs["path"] = path
	return self.create(**kwargs)

As long as the current functionality does not break the current tests we can merge as is :)

but in case, the changes break the current api, we can bump to a 0.2.x release schedule (in that case the breaking API's need a migration docs)

[amirreza-sf80]

As long as the current functionality does not break the current tests we can merge as is :)

hmm, that would be hard to do, as my work is mostly a rewrite

I've changed how path is generated, my logic uses the objects id by default, and lets you choose a different field if needed
as having a fully unique value lets us handle updating the tree easily

I'll think how a backwards compatible change could be done, i don't have any ideas now

[baseplate-admin]

hmm, that would be hard to do, as my work is mostly a rewrite

If this is the case, we can release a v 0.2.x. (or even 1.x.x)

I haven’t given a look at the PR. I will come back to this after i give your approach a review

[baseplate-admin]

Hey @amirreza-sf80, stay safe man.

[amirreza-sf80]

thank you ❤️

[amirreza-sf80]

hi 👋
these changes were merged into django-ltree

[baseplate-admin]

Hello,

Would you like me to port these changes to ltree-2?

[amirreza-sf80]

hi 👋
if they seem good to you.

i can port it as well if you don't have the time

on another note, I've been thinking about adding admin support, admin doesn't currently handle paths, and maybe showing items in a tree like view similar to django-treenode.
what do you think?

[baseplate-admin]

i can port it as well if you don't have the time

Yep yep, I am looking forward to collaborating on the changes together

on another note, I've been thinking about adding admin support, admin doesn't currently handle paths, and maybe showing items in a tree like view similar to django-treenode.

I am stoked for this. Let me know if you need any help regarding this,