feat(wallet): dashboard polish — top-5 transactions + switch flow + NWC dashboard + settings cleanup#571
Open
dmnyc wants to merge 2 commits into
Open
feat(wallet): dashboard polish — top-5 transactions + switch flow + NWC dashboard + settings cleanup#571dmnyc wants to merge 2 commits into
dmnyc wants to merge 2 commits into
Conversation
…ad of 1 The dashboard footer was capped at one transaction. iOS shows up to five rows inline before the "View all" affordance — matching that here. Tapping any row (or "View all") still expands to the full transactions screen.
…eanup Post-connect navigation - When isConnected flips true while currentPage is NwcSetup or SparkSetup, clear the back stack and set currentPage = Home. Fixes the "Wallet" TopAppBar showing over the connected NWC dashboard because the setup screen lingered until the user navigated away. Switch / Disconnect entry on Wallet Settings - iOS-style Card row with SwapHoriz icon + "Switch to a different wallet" in #FF3B30 for both recoverable cases (default Spark and NWC). Section header "Disconnect Wallet" above, explanatory caption below. The destructive non-default Spark delete keeps the filled-red Button because the seed can't be re-derived from nsec — losing it is irreversible. - Confirmation page unified on #FF3B30 across all three flows (icon halo, title, CTA, and "back up first" warning) instead of branching between Material primary orange and Material darker red #D32F2F. - Switching from a default Spark wallet routes back to the wallet-mode picker (Home + NotConnected → renders WalletModeSelectionContent) rather than dropping the user on the Spark sub-screen. NWC entry - QR scan dialog reachable from the connection-string field's trailing icon. Reuses the existing QrScanner component; success populates onConnectionStringChange so paste + scan are both available. NWC dashboard - Lightning-address pill rendered for any wallet mode that carries a lud16 (Spark via Breez SDK, NWC via parsed URI). Removed the redundant "Nostr Wallet Connect" footer below the balance — the in-page top row already brands the connection (NWC logo + node alias). - Adaptive recent-tx count via LocalConfiguration.screenHeightDp (5 / 4 / 3 / 2 rows by tier) so smaller phones don't crowd out the balance + Send/Receive controls. Wallet Settings polish - WalletInfoRow uses a fixed-width label column (widthIn min 110dp, trailing padding) and right-aligned values with maxLines = 1 + TextOverflow.Ellipsis so long relay URLs / lightning addresses truncate cleanly and labels align across rows. - Backup-to-relay now offered for default Spark wallets too — matches iOS, gives users belt-and-braces durability beyond the nsec. Strings + docs - wallet_switch_wallet copy expanded to "Switch to a different wallet"; new wallet_disconnect_section + wallet_switch_wallet_caption. - WALLET_PARITY.md §11.2 checklist items marked done for the parity work landed here and in the preceding two commits.
This was referenced May 26, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second in the slim carve-out series from #556. Two commits, both wallet-screen polish.
Commits
1. fix(wallet): show top 5 recent transactions on dashboard footer instead of 1 —
7f52e0aadaptedTransactionRowreceives the existingbalanceDisplayparameter from main (PR feat(wallet): cycle balance display between sats, fiat, and hidden #562) so the rows render in the user's chosen denomination.2. feat(wallet): parity polish — switch flow, NWC dashboard, settings cleanup —
810afdaFiles
Dropped from the original
fix(wallet): move NWC paste field above the Recommended wallets list(4f88bf9) was the third commit in this cluster. Its entire purpose — reordering the OutlinedTextField vs Recommended-wallets list — is superseded by PR #561's NWC connect screen redesign already inmain(which removed the OutlinedTextField + Recommended list entirely in favour of the iOS-style Paste/Scan card). Carrying the commit forward would produce an empty no-op merge, so it's dropped.Test plan
Carve-out context
Continues the slim-PR series superseding #556. First out was #570 (wallet setup screen — Spark primary). Up next: bolt glow pulse animation.