Conversation
Web app - Mira Studio design system in src/app/globals.css (paper/ink/terra tokens, Instrument Serif + Geist fonts, .hf-* utility classes, gradient ProductImage tones) - Shopper flow: home (magazine tiles), product detail, desktop 2-column cart, desktop 2-column accordion checkout - Seller flow: stat-driven dashboard, dense listings table, KPIs/charts/funnel analytics, with Link-wired sidebar nav - Shared primitives: Icon, Stars, Avatar, ProductImage, Spark/Bars/AreaChart/Donut shadcn/ui added alongside the design system: components.json, lib/utils.ts, button/input/label/card/dialog/dropdown-menu/sonner Tooling and tests - Vitest + Testing Library + jsdom: 26 unit tests for money, Icon, primitives, ShopperTopbar - Playwright: 14 e2e specs covering full shopper journey, cart/checkout, and seller pages; webServer reuses local dev - Biome overrides for shadcn ui dir + globals.css; tsconfig excludes test configs from Next typecheck Repo - Add .mcp.json, .vscode/mcp.json, scheduled_tasks lock pattern in gitignore - Add aspire / aspireify / dotnet-inspect skills under .claude/skills Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Removes Mira Studio pages, custom components, shadcn ui/, and the hf-* utility CSS layer (~5100 lines). DESIGN.md added as the spec the rebuild targets. Build, lint, and tests pass on the empty shell. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…parator, input, scroll-area)
…e green) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…, top products (e2e green) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Apply Biome autoformat + organizeImports across all seller files and remove unused React import in scroll-area; add aria-label + role="img" to sources-donut SVG to satisfy noSvgWithoutTitle. All four verify gates green: lint clean, build succeeds, 23/23 unit tests, 5/5 e2e. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Icons live in the client component (sidebar-nav.tsx) and are looked up by href. Keeping them out of the server-component NAV array avoids the RSC serialization error: function components can't cross the server/client boundary as props. Icons render aria-hidden so the e2e specs that assert link accessible-names by exact text still match. 5/5 e2e green, lint clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ents Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e2e green 1/1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
WebApplicationFactory now starts a daprio/daprd container with an in-memory pubsub component and overrides DaprClient to target its mapped gRPC port, so notification handlers exercise the real publish path without a sidecar race across parallel test classes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a small dev/e2e seeder gated on the SEED_PRODUCTS configuration flag. Loads the 42-listing fixture from SeedData/products.json and inserts via EF Core only when the products table is empty, so it stays idempotent and skips entirely in test environments that don't set the flag. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Introduces src/lib/catalog/api.ts as the server-only Catalog HTTP client (paged products, counts, by-SKU, plus create/update/delete) and src/lib/catalog/actions.ts with matching server actions that revalidate /seller/listings on writes. The three listing helpers in src/lib/seller/data.ts now proxy to the catalog client and the listings, edit, and preview pages await them with export const dynamic = "force-dynamic" so Next no longer tries to prerender against a missing API. The 42-listing mock and its tests are dropped — the same fixture now ships from the Catalog seeder. Vitest gains a server-only stub alias so the api client can be unit- tested under jsdom with mocked fetch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…sword Registers the existing e2e suite as a WithExplicitStart npm resource referencing the web app, so Aspire injects services__web__http__0 and Playwright can be triggered from the dashboard or MCP. The webServer block is removed from playwright.config.ts in favor of that env var (BASE_URL still works for manual runs). The catalog resource gets SEED_PRODUCTS=true outside Testing so the seeder only fires for AppHost-driven runs and not in functional or integration tests. Pins the Postgres password as an AddParameter sourced from user- secrets, fixing the "password authentication failed" loop that hits when WithDataVolume retains a stale random password across runs. CLAUDE.md documents the new e2e workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The "links here" specs were racing Next.js 16's dev-mode SPA navigation against toHaveURL polling and consistently flaking. The test name describes the contract precisely — the sidebar item links here — so asserting the href attribute is both deterministic and ~10× faster than driving a real navigation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces the static client-side slice with real API-driven pagination.
The listings page now reads ?page=N from searchParams, asks the catalog
API for that slice via `getListings({page, limit: 9})`, and hands the
slice plus the API total to ListingsTable. Default windowed page list,
previous/next, current-page highlighting, and disabled edge states all
come from the new `paginate()` helper.
The table footer is rewritten on top of the shadcn Pagination primitive
(installed via `npx shadcn add pagination`) so future paginated tables
share the same idiom; the bespoke chevron buttons and inline page math
are gone.
`paginate()` and `pageHref()` live in lib/pagination.ts with unit
coverage in lib/pagination.test.ts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Appends S02-06/07/08 to TC-S02 covering the next-page advance, last-
page clamp, and out-of-range fallback for /seller/listings.
Adds seller-listings-pagination.spec.ts with three serial Playwright
specs that exercise the same matrix against the live catalog API:
- page 1: prev is aria-disabled, next links to ?page=2
- page 2: next 9 SKUs sorted by views7d DESC, prev returns to page 1
- page 5 (last): trailing 6 SKUs, next is aria-disabled
The file is marked `describe.configure({ mode: "serial" })` and bumps
the per-test timeout to 90s so the first goto absorbs the Next.js dev
cold-compile cost without flaking the rest of the suite.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace full-page navigation on pagination with client-side fetch: - Add /api/listings route handler proxying the Catalog API so the browser has an endpoint to hit (the catalog client is server-only). - Add QueryClientProvider in app/providers.tsx and wrap layout. - ListingsTable uses useQuery with initialData seeded from SSR props and placeholderData: keepPreviousData so prior rows stay visible while the next page fetches. - Keep shadcn Pagination components; suppress <a href> default with onClickCapture + preventDefault + stopPropagation, then setPage and sync the URL via window.history.replaceState (no router round-trip). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Display a Loader2 spinner with "Loading…" label across the top of the listings table whenever the TanStack Query is fetching a new page. The overlay is pointer-events-none so it doesn't block scrolling, and the tbody keeps the previous page's rows visible underneath (keepPreviousData), so the transition reads as client-side rather than a full reload. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The previous spinner sat at the top of the table, so when users scrolled down to click pagination, it was off-screen. Combined with keepPreviousData keeping rows visible during fetch, the result felt like a silent reload. Now show feedback in two places, both of which are in view while the user is interacting with pagination: - A centered "Loading…" pill over the table region (white/40 backdrop) so the table dims as a whole during fetch. Uses <output> for a11y. - An inline spinner next to the "X of Y shown" text in the pagination row footer — directly adjacent to the buttons being clicked. Added e2e/seller-listings-spinner.spec.ts that mocks /api/listings with an 800ms delay and asserts both spinners are visible during the fetch and hidden once page-2 rows arrive. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Make the All/Active/Low/Out/Drafts chips actually filter the table. Chips render as shadcn Badges over next/link, navigating to `?status=<key>`; the active chip carries `aria-current="page"`. Status flows through the server page, the `/api/listings` route handler, `getListings`, and the client-side TanStack query, so pagination preserves the filter. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Chip clicks no longer trigger an RSC round-trip. A new `ListingsBrowser` client wrapper owns the filter state, updates the URL via `window.history.replaceState`, and feeds the status to `ListingsTable`, which refetches via TanStack Query exactly like pagination already does. The chip `<a>` keeps its href so middle-click / cmd-click still open in a new tab; only plain left-clicks are intercepted. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Split the flat `src/lib/seller/{data,types}.ts` (~1.6k LOC) into
feature folders: `brand`, `listings`, `orders`, `analytics`,
`dashboard`, `application`, `onboarding`, `payouts`, `promos`,
`marketing`. Each folder owns its `data.ts` and `types.ts` (and
test file where applicable). Updated 66 consumer imports to the
new paths. No behavior change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mirrors the src/lib/seller/ reorg: each seller component (and its co-located test) moves into a feature folder under src/components/seller/ — analytics, dashboard, listings, marketing, orders, promos, plus shared (sparkline, range-tabs) and shell (sidebar, sidebar-nav, seller-topbar, copy-shop-link). All 75 import sites updated to the new paths. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The new/edit pages were UI mockups; the Catalog API already exposed full product CRUD. Wire them via Next 16 server actions backed by zod validation, plus a confirm-and-delete flow on the edit page. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The new manual test cases verify the wired create/edit/delete flows against a live Aspire stack. TC-S26-05 exposed that the delete confirm modal did not constrain Tab/Shift+Tab, so focus could leak to elements behind the dialog. Add a key handler that cycles between the first and last focusable descendants of the alertdialog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The seller listings table is backed by TanStack Query with a shared QueryClient (staleTime 30s). After a delete, revalidatePath + router.push gave the page fresh server initialData, but TanStack v5 prefers an existing cache entry over initialData — so users who had already visited /seller/listings before deleting saw the row linger for up to 30s. DeleteListingButton now removes the ["listings"] query cache before navigating, so the next ListingsTable mount reseeds from the fresh server data. The dialog is also rebuilt on the shadcn AlertDialog primitive (new src/components/ui/alert-dialog.tsx), dropping the hand-rolled focus trap. Adds an e2e regression that primes the cache by hitting the index before deleting (the existing spec navigated to /edit cold and missed the bug), plus TC-S27 manual QA covering warm-cache, counters, and cold-cache scenarios. Also pulls in the next.config.ts allowedDevOrigins and the global cursor:pointer rule that were sitting unstaged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Three layered fixes so empty/cleared mandatory fields actually flag: - Reject empty price/inventory before z.coerce.number turns "" into 0. - Switch validation mode to onChange so errors track dirty state instead of firing on bare focus+blur. - Opt new-listing-form.tsx and components/ui/form.tsx out of React Compiler with "use no memo" — useFormContext + formState is the one pattern still broken under compiler GA (RHF discussion #12524), so FormMessage never re-rendered on error changes. Added Playwright e2e specs to guard the compiler-interaction failure since vitest doesn't run React Compiler. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… defaults Base UI's Select.Value shows the raw enum value, so the new-listing form trigger showed "draft" instead of "Draft". The Select primitive also lacked inner popup padding, leaving items flush against the edge. - new-listing-form: pass a render-fn child to SelectValue mapping value to label - ui/select: adopt shadcn-on-Radix default CSS (rounded-md trigger with shadow-xs, border popup with p-1, rounded-sm items with py-1.5 pl-2) - .gitignore: ignore .claude/scheduled_tasks.lock Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.