Possible tweak needed for Backdrop 1.33.0.

[laryn]

This module uses module_invoke on field_is_empty a few times -- as of Backdrop 1.33.0 this may cause an error if the instance array is not passed as the third parameter. See an example fix from Paragraphs here (although if the instance is not already loaded in your case, you may need to load it):

• backdrop-contrib/paragraphs@7151030

[herbdool]

I don't think leaving out $instance in module_invoke($field['module'], 'field_is_empty', $field_item, $field) is such a problem (at least not at the moment). None of the modules defining those fields use $instance in their hook_field_is_empty implementations. But there may come a time when a module does use $instance in their implementation so better to pass it.

[herbdool]

I just clued in that text_field_is_empty() requires $instance in 1.33.

[indigoxela]

Yes, it causes a fatal error in field_collection. I used this module to test for a possible fix in core, see backdrop/backdrop-issues#7057 (comment) for steps to reproduce.

Edit: this line needs a tweak: https://github.com/backdrop-contrib/field_collection/blob/1.x-1.x/field_collection.module#L793

Otherwise it causes fatal errors with text fields.

[indigoxela]

Here's a PR: #35 - note that functional tests don't run anymore, but that's a different and old PR (#30).

Anyway: the change to prevent fatals, is minimal and fully backwards compatible.

[oadaeh]

Is the change not needed for line 1807?.

What about the implementation of hook_field_is_empty() at line 753 , since the definition shows it as being part of the signature: https://docs.backdropcms.org/api/backdrop/core%21modules%21field%21field.api.php/function/hook_field_is_empty/1?

[indigoxela]

Is the change not needed for line 1807?.

It is! Nice catch. 👍 I didn't test with required fields. PR updated accordingly.