Product 'bundle' vs 'type' discrepancy not addressed in this port

[steve-v-online]

Entity types have bundles, but in Commerce Products (perhaps other places) the entity's 'bundle' is named 'type' instead.

This was causing an error when I ported Commerce Feeds from Drupal 7 and tried to import an image field that was tied to my product.

To get it working, all I did was add this to the class function list in commerce/modules/product/includes/commerce_product.entity.inc:

public function bundle() {
return $this->type;
}

[argiepiano]

Yes, this modification looks correct and should be added to all entity classes for commerce. If not, they rely on Entity::bundle(), which provides the bundle name for entities that do not support bundles.

As the documentation for Entity::bundle() clearly states: "Subclasses should override this method if supporting bundles."

Would you be able to provide a PR for product and other custom entities (e.g. line items) provided by commerce?