Errors encountered in coder_upgrade/conversions/end.inc

[izmeez]

Using coder_upgrade to port the Drupal 7 feeds_comment_processor module and encountered 2 errors:

ERROR: Creating default object from empty value on line 159 in coder_upgrade/conversions/end.inc (Warning)

ERROR: Call to a member function insertAfter() on null on line 162 in coder_upgrade/conversions/end.inc (Uncaught exception)

After the two errors on a white screen checking the new folder there is a folder for feeds_comment_processor but the file feeds_comment_processor.module only includes the opening @file block.

[izmeez]

It looks like there is a problem with the existing old Drupal 7 module file. Looking into it now.

[izmeez]

Resolved: the old Drupal 7 module file was essentially empty except for the opening comment and had not been removed. Removing it allowed coder_upgrade to run without errors.

[izmeez]

This may be an edge case where a module file is needed as a stub but contains no code. I'm not sure if it is also required by Backdrop CMS. Since the first run created the exact same files despite the errors I wonder if coder_upgrade can be improved to handle this exception?

[bugfolder]

A PR that addresses this edge case would be welcomed.