Skip to content

When reordering home menu item in main menu, WSOD on config staging workflow sites. #5683

@trackleft

Description

@trackleft

Describe the bug

#0 /code/web/modules/contrib/config_readonly/src/Config/ConfigReadonlyStorage.php(79): Drupal\config_readonly\Config\ConfigReadonlyStorage->checkLock()
#1 /code/web/core/lib/Drupal/Core/Config/Config.php(226): Drupal\config_readonly\Config\ConfigReadonlyStorage->write()
#2 /code/web/core/lib/Drupal/Core/Menu/StaticMenuLinkOverrides.php(151): Drupal\Core\Config\Config->save()
#3 /code/web/core/lib/Drupal/Core/Menu/MenuLinkDefault.php(102): Drupal\Core\Menu\StaticMenuLinkOverrides->saveOverride()
#4 /code/web/core/lib/Drupal/Core/Menu/MenuLinkManager.php(330): Drupal\Core\Menu\MenuLinkDefault->updateLink()
#5 /code/web/core/modules/menu_ui/src/MenuForm.php(525): Drupal\Core\Menu\MenuLinkManager->updateDefinition()
#6 /code/web/core/modules/menu_ui/src/MenuForm.php(202): Drupal\menu_ui\MenuForm->submitOverviewForm()
#7 /code/web/core/lib/Drupal/Core/Form/FormSubmitter.php(108): Drupal\menu_ui\MenuForm->submitForm()
#8 /code/web/core/lib/Drupal/Core/Form/FormSubmitter.php(45): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers()
#9 /code/web/core/lib/Drupal/Core/Form/FormBuilder.php(615): Drupal\Core\Form\FormSubmitter->doSubmitForm()
#10 /code/web/core/lib/Drupal/Core/Form/FormBuilder.php(347): Drupal\Core\Form\FormBuilder->processForm()
#11 /code/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
#12 [internal function]: Drupal\Core\Controller\FormController->getContentResult()
#13 /code/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#14 /code/web/core/lib/Drupal/Core/Render/Renderer.php(634): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::wrapControllerExecutionInRenderContext():121}()
#15 [internal function]: Drupal\Core\Render\Renderer::{closure:Drupal\Core\Render\Renderer::executeInRenderContext():634}()
#16 /code/web/core/lib/Drupal/Core/Render/Renderer.php(649): Fiber->resume()
#17 /code/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
#18 /code/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#19 /code/vendor/symfony/http-kernel/HttpKernel.php(183): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::onController():96}()
#20 /code/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#21 /code/web/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle()
#22 /code/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#23 /code/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#24 /code/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(118): Drupal\Core\StackMiddleware\ContentLength->handle()
#25 /code/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(92): Drupal\page_cache\StackMiddleware\PageCache->pass()
#26 /code/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#27 /code/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#28 /code/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(53): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#29 /code/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(54): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#30 /code/web/core/lib/Drupal/Core/DrupalKernel.php(745): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#31 /code/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#32 {main}

To Reproduce

Use config staging site in test or live
Attempt to rearrange home menu item in main menu.
See error above in log.

Proposed resolution

Add core.menu.static_menu_link_overrides to config ignore whitelist

Expected behavior

Content admin or editor can rearrange menu items.

Metadata

Metadata

Assignees

Labels

3.4.x onlypatch releaseIssues to be included in the next patch release

Type

No fields configured for Bug.

Projects

Status
In review

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions