The method definition and behaviour of NindLocalAmose::getDocTerms() should evolve to embrace the need of corpus migration and slight changes in the configuration of the Amose Server.
The possibility of "not-found" term arise when the corpus and the MediaData configuration evolves : I suggest that the NindLocalAmose::getDocTerms() method avoid any Exception throw because it stops the filling of the end of the termsSet . In the context of highlighted NE display of documents, this early stopping is annoying, whereas one term out of the whole termsSet may be skiped with limited impact.
To conclude, one could change the definition of the method to return an Integer value telling the number of notfound terms. This leaves the handling of this error to the caller , eg amose_nindindex.
See the disabled exception throw in branch getDocTerms_noExcept
Any comment ?
The method definition and behaviour of
NindLocalAmose::getDocTerms()should evolve to embrace the need of corpus migration and slight changes in the configuration of the Amose Server.The possibility of "not-found" term arise when the corpus and the MediaData configuration evolves : I suggest that the
NindLocalAmose::getDocTerms()method avoid any Exception throw because it stops the filling of the end of the termsSet . In the context of highlighted NE display of documents, this early stopping is annoying, whereas one term out of the whole termsSet may be skiped with limited impact.To conclude, one could change the definition of the method to return an Integer value telling the number of notfound terms. This leaves the handling of this error to the caller , eg
amose_nindindex.See the disabled exception throw in branch getDocTerms_noExcept
Any comment ?