Skip to content

Reviewer Quick Checklist #444

Description

@ayanimea

Reviewer Quick Checklist

Use this checklist before merge.


Architecture

  • No threshold literals
  • Config imported correctly
  • Structural logic isolated
  • Suggestion engine deterministic
  • Snap logic centralized

Structural Enforcement

  • Simultaneous limit enforced on create
  • Simultaneous limit enforced on edit
  • Simultaneous limit enforced on drag
  • Overlap includes prep + travel

Load Logic

  • Load includes prep + travel
  • Day duration computed dynamically
  • Load memoized
  • No render-loop calculations

UI

  • Week view visually calmer
  • Day view unchanged layout
  • Indicators static
  • Tokens used for all shadows and blends

Suggestions

  • Suggestions snap correctly
  • Suggestions respect structural rules
  • Sorting priority correct
  • Deterministic output

Tests

  • Snap rounding tested
  • Overlap logic tested
  • Threshold boundary tested
  • Deterministic suggestion ordering tested
  • Config invariant tested

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions