Skip to content

Verify and potentially fix External smart contract calls #8

@ademidun

Description

@ademidun

Our Market.Sol smart Contracts calls the transferFrom() function on any provided nftContract address. These may not always be valid IERC721 compliant smart contract addresses. Is this a security vulnerability? Confirm that this is either a safe assumption to make or what can be done to improve such calls.

Example:

IERC721(nftContract).transferFrom(msg.sender, address(this), tokenId);
return itemId;

This tweet suggests using safeTransferFrom. See: https://gist.github.com/ecmendenhall/9408082d8f3cfe50076642d8745fc6d3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions