From 2179bf2de33a03831fa538936a3c0bac4e614703 Mon Sep 17 00:00:00 2001
From: George Joseph <gjoseph@sangoma.com>
Date: Fri, 19 Jun 2026 18:29:01 -0600
Subject: [PATCH] rest_api/external_interaction/attended_transfer: Add delay to
 end of referer scenarios.

In these tests, the referer scenarios are 3pcc masters and the referee scenarios
are 3pcc slaves.  If the master ends before the slave, the slave will fail
and cause the test to fail even though it actually passed.  Normally, Asterisk sends
a BYE to the referee first, then the master which is fine but occasionally, it sends
the BYE to the master first which causes the error.  Adding a delay to the end of
the referer script ensures that even if it receives the BYE first, it won't end before
the referee.  The test case kills the scenarios in the correct order so in practice,
the added delay doesn't actually add overall elapsed time to the test.
---
 .../non_stasis_app_to_stasis_bridge/sipp/referer.xml  | 11 ++++++++---
 .../sipp/referer.xml                                  | 11 ++++++++---
 .../stasis_bridge_to_non_stasis_app/sipp/referer.xml  |  9 +++++++++
 .../stasis_bridge_to_stasis_app/sipp/referer.xml      |  9 +++++++++
 .../sipp/referer.xml                                  |  9 ++++++++-
 .../different_stasis_app/sipp/referer.xml             | 11 ++++++++---
 .../same_stasis_app/sipp/referer.xml                  | 11 ++++++++---
 .../same_stasis_app_accepted/sipp/referer.xml         | 11 ++++++++---
 8 files changed, 66 insertions(+), 16 deletions(-)

diff --git a/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/sipp/referer.xml b/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/sipp/referer.xml
index b67a00465..590f65c74 100644
--- a/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/sipp/referer.xml
+++ b/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/sipp/referer.xml
@@ -157,9 +157,14 @@
     ]]>
   </send>
 
-  <!-- Keep the call open for a while in case the 200 is lost to be     -->
-  <!-- able to retransmit it if we receive the BYE again.               -->
-  <pause milliseconds="500"/>
+  <!--
+  This scenario is the 3pcc master so if it ends before the referee scenario,
+  the referee scenario will abort and the test will fail.  The two second pause
+  will allow the referee scenario to end first.  The the test case will kill this
+  scenario before the two seconds is up so no time is actually added to the overall
+  run time.
+  -->
+  <pause milliseconds="2000"/>
 
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
diff --git a/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/sipp/referer.xml b/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/sipp/referer.xml
index c48b6e184..e35c49720 100644
--- a/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/sipp/referer.xml
+++ b/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/sipp/referer.xml
@@ -157,9 +157,14 @@
     ]]>
   </send>
 
-  <!-- Keep the call open for a while in case the 200 is lost to be     -->
-  <!-- able to retransmit it if we receive the BYE again.               -->
-  <pause milliseconds="500"/>
+  <!--
+  This scenario is the 3pcc master so if it ends before the referee scenario,
+  the referee scenario will abort and the test will fail.  The two second pause
+  will allow the referee scenario to end first.  The the test case will kill this
+  scenario before the two seconds is up so no time is actually added to the overall
+  run time.
+  -->
+  <pause milliseconds="2000"/>
 
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
diff --git a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/sipp/referer.xml b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/sipp/referer.xml
index f536aad52..0ed2342ad 100644
--- a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/sipp/referer.xml
+++ b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/sipp/referer.xml
@@ -169,6 +169,15 @@
   </send>
   <recv response="200" />
 
+  <!--
+  This scenario is the 3pcc master so if it ends before the referee scenario,
+  the referee scenario will abort and the test will fail.  The two second pause
+  will allow the referee scenario to end first.  The the test case will kill this
+  scenario before the two seconds is up so no time is actually added to the overall
+  run time.
+  -->
+  <pause milliseconds="2000"/>
+
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
 
diff --git a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/sipp/referer.xml b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/sipp/referer.xml
index f536aad52..0ed2342ad 100644
--- a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/sipp/referer.xml
+++ b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/sipp/referer.xml
@@ -169,6 +169,15 @@
   </send>
   <recv response="200" />
 
+  <!--
+  This scenario is the 3pcc master so if it ends before the referee scenario,
+  the referee scenario will abort and the test will fail.  The two second pause
+  will allow the referee scenario to end first.  The the test case will kill this
+  scenario before the two seconds is up so no time is actually added to the overall
+  run time.
+  -->
+  <pause milliseconds="2000"/>
+
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
 
diff --git a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app_ari_only/sipp/referer.xml b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app_ari_only/sipp/referer.xml
index e78e840cc..09ecdf420 100644
--- a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app_ari_only/sipp/referer.xml
+++ b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app_ari_only/sipp/referer.xml
@@ -169,7 +169,14 @@
   </send>
   <recv response="200" />
 
-  <pause milliseconds="1000" />
+  <!--
+  This scenario is the 3pcc master so if it ends before the referee scenario,
+  the referee scenario will abort and the test will fail.  The two second pause
+  will allow the referee scenario to end first.  The the test case will kill this
+  scenario before the two seconds is up so no time is actually added to the overall
+  run time.
+  -->
+  <pause milliseconds="2000"/>
 
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
diff --git a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/sipp/referer.xml b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/sipp/referer.xml
index fd880307e..35ebcc594 100644
--- a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/sipp/referer.xml
+++ b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/sipp/referer.xml
@@ -157,9 +157,14 @@
   </send>
   <recv response="200" />
 
-  <!-- Keep the call open for a while in case the 200 is lost to be     -->
-  <!-- able to retransmit it if we receive the BYE again.               -->
-  <pause milliseconds="500"/>
+  <!--
+  This scenario is the 3pcc master so if it ends before the referee scenario,
+  the referee scenario will abort and the test will fail.  The two second pause
+  will allow the referee scenario to end first.  The the test case will kill this
+  scenario before the two seconds is up so no time is actually added to the overall
+  run time.
+  -->
+  <pause milliseconds="2000"/>
 
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
diff --git a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/sipp/referer.xml b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/sipp/referer.xml
index fd880307e..35ebcc594 100644
--- a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/sipp/referer.xml
+++ b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/sipp/referer.xml
@@ -157,9 +157,14 @@
   </send>
   <recv response="200" />
 
-  <!-- Keep the call open for a while in case the 200 is lost to be     -->
-  <!-- able to retransmit it if we receive the BYE again.               -->
-  <pause milliseconds="500"/>
+  <!--
+  This scenario is the 3pcc master so if it ends before the referee scenario,
+  the referee scenario will abort and the test will fail.  The two second pause
+  will allow the referee scenario to end first.  The the test case will kill this
+  scenario before the two seconds is up so no time is actually added to the overall
+  run time.
+  -->
+  <pause milliseconds="2000"/>
 
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
diff --git a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app_accepted/sipp/referer.xml b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app_accepted/sipp/referer.xml
index 994d5aeed..ba28c603d 100644
--- a/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app_accepted/sipp/referer.xml
+++ b/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app_accepted/sipp/referer.xml
@@ -158,9 +158,14 @@
   </send>
   <recv response="200" />
 
-  <!-- Keep the call open for a while in case the 200 is lost to be     -->
-  <!-- able to retransmit it if we receive the BYE again.               -->
-  <pause milliseconds="500"/>
+  <!--
+  This scenario is the 3pcc master so if it ends before the referee scenario,
+  the referee scenario will abort and the test will fail.  The two second pause
+  will allow the referee scenario to end first.  The the test case will kill this
+  scenario before the two seconds is up so no time is actually added to the overall
+  run time.
+  -->
+  <pause milliseconds="2000"/>
 
   <!-- definition of the response time repartition table (unit is ms)   -->
   <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>