A Bunch of Small Changes#154
Closed
helloimalastair wants to merge 2 commits into
Closed
Conversation
- bump wrangler ^4.54.0 → ^4.80.0 across all packages/fixtures(for secrets.required support) - add $schema to all wrangler.jsonc files - add secrets.required declarations to wrangler configs - remove hardcoded bucket_name from r2_buckets bindings(utilizes auto-provisioning so you can choose your own buckets/have wrangler create them) - add `ignoredBuiltDependencies`/minimumReleaseAge` to root pnpm config
ascorbic
reviewed
May 4, 2026
Owner
ascorbic
left a comment
ascorbic
left a comment
There was a problem hiding this comment.
Thanks. The secrets.required changes are worth bringing in, but can you restrict this to just the changes needed for that, as well as pointing to config schema in the installed wrangler package.
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "$schema": "https://cdn.jsdelivr.net/npm/wrangler@4.80.0/config-schema.json", | |||
Owner
There was a problem hiding this comment.
This can be loaded from in node_modules, which has the benefit of tracking the insgtalled version
Author
|
Ah sorry, forgot to look at this again, got a bit distracted with work. Will take a look again when I get time. Will spin it off into a separate PR, and scope it down a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107
wrangler^4.54.0→^4.80.0across all packages/fixtures(forsecrets.requiredsupport)$schemato allwrangler.jsoncfilessecrets.requireddeclarations to wrangler configsbucket_namefromr2_bucketsbindings(utilizes auto-provisioning so you can choose your own buckets/have wrangler create them)ignoredBuiltDependencies/minimumReleaseAgeto rootpnpmconfigMost of these are QoL changes, so not necessarily expecting these to be merged.