fix(ci): bypass delegation-guard during merge conflict resolution - #133
Conversation
|
Updated |
|
I have a full picture. Here is the review. PR #133 — Delegation Guard: Merge-Conflict BypassBuckets touched: Punch list
Correct and narrowly scoped:
The test repo setup (
Removing the The phrase "for the handoff path" is slightly opaque but not wrong. Non-blocking.
Clean, no issues. Working-tree state (not a PR defect) The review context shows staged/unstaged reverts of the bypass code in the working tree. These are not part of the PR commits and appear to be artifacts of a prior review run. The PR commits at
Verdict: APPROVE |
|
PR #133 is ready to merge: the PR title now uses the allowed ci scope, crates/plumb-mcp/AGENTS.md is back under the 60-line preflight cap, .claude-pr/ is ignored, and Claude review punch-list items were addressed by narrowing the merge-conflict bypass to only the unresolved Rust file plus adding negative regression coverage. GitHub CI is green after rerunning one transient setup-layer Determinism failure, and the latest Claude review verdict is APPROVE. |
Resolves the conflicts that arose after PR #131 (lint_url over real http(s)://) and PR #133 (delegation-guard merge bypass) merged into main while this branch carried PR #132 (get_config tool). - crates/plumb-mcp/src/lib.rs: keep both new use lines — plumb_cdp::{BrowserDriver, ChromiumDriver, ChromiumOptions, Target, is_fake_url} from main and plumb_config::ConfigError from this branch. Bring in ViewportKey alongside Config/PlumbSnapshot/etc. - Cargo.lock: union plumb-cdp and plumb-config under plumb-mcp. Note: local cargo check is blocked by a disk-space failure in the sandbox toolchain ('No space left on device' while syncing the 1.95.0 channel). Verification deferred to CI.
Summary
.claude/hooks/delegation-guard.shto permit root Rust source edits while the worktree has unmerged paths.Why
Merge conflict marker arbitration is mechanical cleanup, not new Rust implementation work, so forcing it through
01-implementerconflicts with that subagent's TDD-oriented contract.Validation
bash -n .claude/hooks/delegation-guard.sh .claude/hooks/tests/test_delegation_guard_subagent.shbash .claude/hooks/tests/test_delegation_guard_subagent.shgit diff --checkcargo fmt --checkpassed after installing the pinned Rust1.95.0toolchain under/workspace.cargo clippy --workspace --all-targets --all-features -- -D warningscould not complete in this container because no C linker (cc,gcc, orclang) is installed. A bundledrust-lldretry also failed due missing libc development linker names/startup environment, socargo testwas not run here for the same environment reason.