test: cover hub.component sidebar gating and routerLinks#5231
Closed
Ma77Ball wants to merge 7 commits into
Closed
Conversation
…xisting-some-null # Conflicts: # amber/src/test/scala/org/apache/texera/web/service/ExecutionsMetadataPersistServiceSpec.scala
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5231 +/- ##
============================================
- Coverage 48.55% 48.55% -0.01%
Complexity 2372 2372
============================================
Files 1042 1042
Lines 39971 39971
Branches 4252 4252
============================================
- Hits 19408 19407 -1
- Misses 19414 19416 +2
+ Partials 1149 1148 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
sidebarTabs.*_enabledgating, all-enabled rendering, exclusion of disabled tabs,routerLinkbindings to the three routing constants, andisLogininput passthrough.HubComponentin a test host<ul nz-menu>sonz-menu-itemdirectives resolve their DI tokens the same way they do under the dashboard at runtime.routerLinkvia the directive'srouterLinkInputsignal since therouterLinkinput is a write-only setter andng-reflect-router-linkis not populated in the Vitest environment.Any related issues, documentation, or discussions?
Closes: #5224
How was this PR tested?
yarn test --include='src/app/hub/component/hub.component.spec.ts': 9 passed, 0 failed.yarn format:fix: 506 files unchanged.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF