Replace custom GraphLogger with DependencyGraphDumper in dependency resolution - #12639
Merged
slawekjaranowski merged 1 commit intoJul 30, 2026
Merged
Conversation
…cy resolution Refactored the dependency graph logging by removing the custom `GraphLogger` implementation in both `DefaultProjectDependenciesResolver` and `DefaultPluginDependenciesResolver` and replacing it with `DependencyGraphDumper`. Simplifies code and leverages existing utility for consistent logging.
Member
Author
gnodet
approved these changes
Jul 30, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Clean refactoring that removes ~166 lines of duplicated custom GraphLogger inner classes from both DefaultProjectDependenciesResolver and DefaultPluginDependenciesResolver, replacing them with the library-provided DependencyGraphDumper from maven-resolver-util (already a dependency).
This is a good change:
- The two
GraphLoggerclasses had "Keep this class in sync with..." comments, indicating a recognized maintenance burden. This duplication is now eliminated. DependencyGraphDumperprovides richer diagnostic output (tree-style indentation, range membership, conflict winner info) consistent with how Maven 4'simpl/maven-corealready uses the sameDependencyGraphDumper(logger::debug)pattern.- The minor format differences (tree-style
+-/\-/|instead of 3-space indent,[scope]instead of:scope) are improvements to diagnostic output, not a public API contract. - No tests exist for the old debug graph logging, which is expected — this is diagnostic output.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
cstamas
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the dependency graph logging by removing the custom
GraphLoggerimplementation in bothDefaultProjectDependenciesResolverandDefaultPluginDependenciesResolverand replacing it withDependencyGraphDumper.Simplifies code and leverages existing utility for consistent logging.