Conversation
New file src/site/xdoc/faq.xml with basic structure. Uncommented FAQ navigation item in site.xml.
gnodet
requested changes
Jul 30, 2026
gnodet
left a comment
Contributor
There was a problem hiding this comment.
The idea of adding a FAQ page is welcome, but the current content has a factual error and formatting inconsistencies:
Verified issues:
- Factual error (high): The FAQ states "Maven 4.x requires Java 8 or later" but the project's
pom.xmldefines<javaVersion>17</javaVersion>— Maven 4.x requires Java 17, not Java 8. This would give users incorrect information. - License header format (medium): The ASF license header is on a single line, while the existing xdoc file (
index.xml) uses the standard multi-line format. This is inconsistent with the project's established convention. - Wrong issue reference (low): The PR body says "Fixes #3" but issue #3 is "Reverting some unexpected aether dependency changes to the top-level pom" — an unrelated, already-closed issue. Merging would incorrectly reference that issue.
Please fix the Java version requirement to Java 17 and reformat the license header to match the multi-line format used in src/site/xdoc/index.xml.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
| <subsection name="Getting Started"> | ||
|
|
||
| <p><b>Q: What is the minimum Java version required for Maven?</b></p> | ||
| <p>A: Maven 4.x requires Java 8 or later. For specific version requirements, see the <a href="https://maven.apache.org/install.html">installation guide</a>.</p> |
Member
There was a problem hiding this comment.
Maven 4.x requires Java 8
😄 ?
Member
|
I would like to managed such FAQ at docs site somewhere: https://maven.apache.org/index.html We have in many places FAQ which is outdated ... I afraid that this will be also outdated soon 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3.