Investigate build errors in flatten plugin with 3.10.0

[slawekjaranowski]

Affected version

3.10.0

Bug description

Build project: https://github.com/mojohaus/flatten-maven-plugin

Maven version / commit	Passed	Failed	Change from previous result
Maven 3.9.16 (2bdd9fd)	95	0	Baseline
Maven 3.10.0-rc-1 (1f7f1a5)	81	14	Introduces 14 failures
Maven 3.10.0-SNAPSHOT (8bd06ad)	81	14	No change
Maven 3.10.0-SNAPSHOT (e2c2b82)	91	4	Fixes 11 failures; resolve-properties-ci fails
Maven 3.10.0-SNAPSHOT (5ca34f1)	91	4	No change

The 14 failures introduced before or in 1f7f1a54 are:

• flatten-dependency-all-provided-direct
• flatten-dependency-all-depmgnt-simple
• flatten-dependency-all-transitive
• flatten-dependency-all-simple
• flatten-dependency-all-both-test-and-transitive
• profile-with-deps-inherit-parent-depMgmt-flatten-dep-all-active
• flatten-dependency-all-depmgnt-transitive-complex
• flatten-dependency-all-depmgnt-provided-transitive
• flatten-dependency-all-resolution-order
• flatten-dependency-all-depmgnt-transitive
• flatten-dependency-all-depmgnt-resolution-order-transitive
• flatten-dependency-all-provided-children
• flatten-dependency-all-classifier
• flatten-dependency-all-provided-transitive

Failures remaining from e2c2b827 onward:

• flatten-dependency-all-transitive
• profile-with-deps-inherit-parent-depMgmt-flatten-dep-all-active
• flatten-dependency-all-depmgnt-transitive-complex
• resolve-properties-ci

reference:

• Maven 3.10.0-rc1 compatibility mojohaus/flatten-maven-plugin#513

[cstamas]

Cause (of reported issue) looks exactly like this PR was fix for:
apache/maven-resolver@8532889

Can you try with resolver that has this change included, or better, with staged 2.0.21?

[cstamas]

Another interesting (and to me seems related) issue:
apache/maven-shade-plugin#819

[cstamas]

Built locally Maven 3.10.0-SNAPSHOT with staged Resolver 2.0.21 and I have to confirm:

[INFO] Build Summary:
[INFO]   Passed: 91, Failed: 4, Errors: 0, Skipped: 1
[INFO] -------------------------------------------------
[ERROR] The following builds failed:
[ERROR] *  flatten-dependency-all-depmgnt-transitive-complex/pom.xml
[ERROR] *  flatten-dependency-all-transitive/pom.xml
[ERROR] *  profile-with-deps-inherit-parent-depMgmt-flatten-dep-all-active/pom.xml
[ERROR] *  resolve-properties-ci/pom.xml

[cstamas]

Out of 4 failed ITs, 3 are having exclusions missing (hence the shade link IMO), and one due this:

[ERROR] Invalid Collect Request: null -> [org.codehaus.mojo.flatten.its:dep:jar:small:1.2.3.4 (compile), org.codehaus.mojo.flatten.its:dep:jar:${small1}:1.2.3.1 (compile), org.codehaus.mojo.flatten.its:dep:jar:small2:revision (compile)] < [mrm-maven-plugin (http://localhost:37813, default, releases+snapshots)]
java.lang.IllegalArgumentException: Invalid Collect Request: null -> [org.codehaus.mojo.flatten.its:dep:jar:small:1.2.3.4 (compile), org.codehaus.mojo.flatten.its:dep:jar:${small1}:1.2.3.1 (compile), org.codehaus.mojo.flatten.its:dep:jar:small2:revision (compile)] < [mrm-maven-plugin (http://localhost:37813, default, releases+snapshots)]
    at org.eclipse.aether.internal.impl.DefaultRepositorySystemValidator.mayThrow (DefaultRepositorySystemValidator.java:62)
    at org.eclipse.aether.internal.impl.DefaultRepositorySystemValidator.validateCollectRequest (DefaultRepositorySystemValidator.java:220)
    at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies (DefaultRepositorySystem.java:321)
    at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:154)
    at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:231)
    at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:140)
    at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:364)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:322)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:220)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:181)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:79)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:169)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:166)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:106)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:74)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:121)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:179)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:1017)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:299)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:219)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke (Method.java:580)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:362)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
    Suppressed: java.lang.IllegalArgumentException: Not fully interpolated dependency org.codehaus.mojo.flatten.its:dep:jar:${small1}:1.2.3.1 (compile)
        at org.apache.maven.internal.aether.MavenValidator.validateDependency (MavenValidator.java:78)
        at org.eclipse.aether.internal.impl.DefaultRepositorySystemValidator.validateCollectRequest (DefaultRepositorySystemValidator.java:200)
        at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies (DefaultRepositorySystem.java:321)
        at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:154)
        at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:231)
        at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:140)
        at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:364)
        at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:322)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:220)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:181)
        at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:79)
        at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:169)
        at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:166)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:106)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:74)
        at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:121)
        at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
        at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:179)
        at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
        at org.apache.maven.cli.MavenCli.execute (MavenCli.java:1017)
        at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:299)
        at org.apache.maven.cli.MavenCli.main (MavenCli.java:219)
        at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
        at java.lang.reflect.Method.invoke (Method.java:580)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:362)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)

This is just Maven being grumpy 😄 due validator added:
e2c2b82

Hence, IMHO this IT is wrong, the interpolation needs fixing.
The missing exclusions..... let's summon @ascheman

[slawekjaranowski]

• resolve-properties-ci

we have added Validator

 Suppressed: java.lang.IllegalArgumentException: Not fully interpolated dependency org.codehaus.mojo.flatten.its:dep:jar:${small1}:1.2.3.1 (compile)
        at org.apache.maven.internal.aether.MavenValidator.validateDependency (MavenValidator.java:78)

[slawekjaranowski]

fixes in

• Fix for Maven 3.10.x mojohaus/flatten-maven-plugin#517

[ascheman]

@cstamas we re-checked the three "missing exclusions" ITs on 3.10.0-SNAPSHOT — not maven-shade-plugin#819, different mechanism.

@slawekjaranowski's #517 already nails it: for flattenDependencyMode=all, flatten reads each dependency's exclusions via readArtifactDescriptor(artifact, null /*repos*/, …), which on 3.10 / resolver 2.x can't resolve the MRM-served fixtures without repositories → empty descriptor → no <exclusion> written. His one-line project.getRemoteProjectRepositories() fixes it — reproduced here: flatten-dependency-all-transitive flips from core missing its exclusion (assertion fails) to <exclusion>…:dep</exclusion> present and green.

So plugin-side, #517 covers it; shade#819 stays separate (that one's read-side node pruning).

[cstamas]

Yup, @slawekjaranowski and @ascheman Thanks, looks good!