[MTOOLCHAINS-3] PlexusConfiguration behavior in ToolchainConverter

[jira-importer]

Tomas Radej opened MTOOLCHAINS-3 and commented

Hi,

when packaging the Toolchains plugin to Fedora, I saw that the ToolchainConverter class of the Toolchains plugin depends on the old behavior of the PlexusConfiguration class, i. e. the getValue() and getName() methods throwing a PlexusConfigurationException. However, the new behavior of the PlexusConfiguration class (as found in Sonatype's Sisu, whose goal is to replace Plexus) does not throw this exception, which causes the Toolchain plugin not to compile when using the new library.

The point of this bug is to consult with you moving from plexus-container-default to sisu-inject-plexus, thus removing the try/catch block in src/main/java/org/apache/maven/plugin/toolchain/ToolchainConverter.java, line 84. A patch to perform that action is attached.

Thank you, Tomas Radej

---

Affects: 1.0

Attachments:

• plexus-to-sisu.patch (1.46 kB)

[jira-importer]

Hervé Boutemy commented

if we do such a change, the plugin won't work with Maven 2 any more

this patch can be applied when we upgrade to Maven 3 requirement

[jira-importer]

James Gough commented

I've investigated this JIRA and the proposed patch. It looks to me like this patch has actually been applied previously during refactoring. See:

git diff 3913aef~ 3913aef

I also noticed that the configuration for sisu-inject-plexus is derived from maven-plugin-api, which I don't think we want to override. The version that is pulled in 1.4.2 no longer has the exceptions mentioned above.

+- org.apache.maven:maven-plugin-api:jar:3.0:compile
 |  +- org.apache.maven:maven-model:jar:3.0:compile
 |  +- org.apache.maven:maven-artifact:jar:3.0:compile
 |  \- org.sonatype.sisu:sisu-inject-plexus:jar:1.4.2:compile

[jira-importer]

Robert Scholte commented

Seems to be fixed as part of MTOOLCHAINS-15