From 7a5a21ba8b385d03d8e58ecf9505fc997a1b2b87 Mon Sep 17 00:00:00 2001
From: Elliotte Rusty Harold <elharo@ibiblio.org>
Date: Wed, 4 Feb 2026 07:41:38 -0500
Subject: [PATCH 1/2] Prefer StringBuilder for local variables

---
 src/main/java/org/apache/maven/shared/utils/StringUtils.java  | 4 ++--
 .../java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/maven/shared/utils/StringUtils.java b/src/main/java/org/apache/maven/shared/utils/StringUtils.java
index 0cd9e048..a0cb37a7 100644
--- a/src/main/java/org/apache/maven/shared/utils/StringUtils.java
+++ b/src/main/java/org/apache/maven/shared/utils/StringUtils.java
@@ -1321,7 +1321,7 @@ public static String uncapitalise(String str) {
             if (length == 0) {
                 return "";
             } else {
-                return new StringBuffer(length)
+                return new StringBuilder(length)
                         .append(Character.toLowerCase(str.charAt(0)))
                         .append(str, 1, length)
                         .toString();
@@ -1723,7 +1723,7 @@ public static String reverse(String str) {
         if (str == null) {
             return null;
         }
-        return new StringBuffer(str).reverse().toString();
+        return new StringBuilder(str).reverse().toString();
     }
 
     /**
diff --git a/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java b/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
index 4adb2784..fe09a9cd 100644
--- a/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
+++ b/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
@@ -206,7 +206,7 @@ public static void writeComment(XMLWriter writer, String comment, int indent, in
         int magicNumber = indentation.length() + columnSize - "-->".length() - 1;
         String[] sentences = StringUtils.split(comment, CRLF);
 
-        StringBuffer line = new StringBuffer(indentation + "<!-- ");
+        StringBuilder line = new StringBuilder(indentation + "<!-- ");
         for (String sentence : sentences) {
             String[] words = StringUtils.split(sentence, " ");
             for (String word : words) {

From 518430a90646e8ef60d7dfd451430d11f5cdff98 Mon Sep 17 00:00:00 2001
From: Elliotte Rusty Harold <elharo@ibiblio.org>
Date: Wed, 4 Feb 2026 17:35:58 -0500
Subject: [PATCH 2/2] StringBuilder

---
 .../java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java b/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
index fe09a9cd..c4a6b015 100644
--- a/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
+++ b/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
@@ -221,7 +221,7 @@ public static void writeComment(XMLWriter writer, String comment, int indent, in
                         line.append("-->").append(CRLF);
                         writer.writeMarkup(line.toString());
                     }
-                    line = new StringBuffer(indentation + "<!-- ");
+                    line = new StringBuilder(indentation + "<!-- ");
                     line.append(word).append(' ');
                 } else {
                     line.append(word).append(' ');