[MSHARED-1122] FileUtils: avoid getCanonicalPath()

[jira-importer]

Jörg Kubitz opened MSHARED-1122 and commented

On JDK 11 the result has been cached with in JVM.
Since JDK 12 the result is not cached anymore by default (See https://bugs.openjdk.java.net/browse/JDK-8207005) and now very slow on windows.

For org.apache.maven.shared.utils.io.FileUtils.copyFile(File, File)
please use java.nio.file.Files.isSameFile(Path, Path) instead.

note: it's needed to call file.exists() before using Files.isSameFile() or catch NoSuchFileException 

@see

https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/180308/10/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFile.java

for a similar fix.

Here is a screenshot of sampling eclipse showing getCanonicalPath() as a hotspot:

!image-2022-08-22-18-18-52-811.png!

---

Attachments:

• image-2022-08-22-18-18-52-811.png (59.70 kB)

Remote Links:

• GitHub Pull Request #114
  

Backported to: maven-shared-utils-3.4.0

[jira-importer]

Jörg Kubitz commented

proposed fix tested with org.apache.maven.shared.utils.io.FileUtilsTest.copyFileWithNoFiltersAndLastModifiedDateOfZeroAndNoDestination()

[jira-importer]

Slawomir Jaranowski commented

By the way FileUtils#copyFile is deprecated ...