[MSHARED-685] DirectoryScanner#checkSymlinkBehaviour() does not use assert*

[jira-importer]

Karl Heinz Marbaise opened MSHARED-685 and commented

Add assertions to org.apache.maven.shared.utils.io.DirectoryScannerTest#checkSymlinkBehaviour test

---

Affects: maven-shared-utils-3.3.3

Attachments:

• MSHARED-685-maven-shared-utils.patch (3.45 kB)

Remote Links:

• GitHub Pull Request #16
  

0 votes, 6 watchers

[jira-importer]

Nishant Raut commented

Hello, I would like to work on it, attached is patch. Is this is what is expected if not can you guide me.

[jira-importer]

Robert Scholte commented

The title and description are not clear enough to me to understand the issue and how to sovle it, so it would be nice if Karl Heinz Marbaise could improve that.
Every good patch has a test, in general a unittest to confirm it is fix and the prevent regression when code is changed in the future.

[jira-importer]

Robert Scholte commented

Karl Heinz Marbaise does this patch match your requirements?

[jira-importer]

Elliotte Rusty Harold commented

There's a patch. Can we resolve his one way or the other?

[jira-importer]

Sylwester Lachiewicz commented

The proposed patch was invalid - we need to add assertions to DirectoryScannerTest#checkSymlinkBehaviour - description updated.