[MSHARED-567] remove dependency on Maven core

[jira-importer]

Hervé Boutemy opened MSHARED-567 and commented

while creating an API for java tool in MSHARED-304, Maven core's Toolchain API is used: this makes maven-shared-utils dependant on Maven core.
Since maven-shared-utils is expected to be a fundamental utilities library, ideally which could replace plexus-utils, depending on Maven core will cause a chicken and egg issue, since Maven core should be able to use maven-shared-utils

for example, I'm working on MSHARED-562 and this dependency makes me think that I cannot let the new code in maven-shared-utils and create a dependency from Maven core on maven-shared-utils...

---

Affects: maven-shared-utils-3.1.0

Issue Links:

• MSHARED-304 Create a API for java tool

• MSHARED-562 add an API to create messages with consistent and configurable colors

[jira-importer]

Hervé Boutemy commented

while thinking at it, I see 2 reasonable options:

1. replace setToolchain( Toolchain toolchain ) with setToolchain( Object toolchain ) and use reflection for the findTool(String) call
2. simply remove this method: honestly, for the calling code, instead of setToolchain(..), coding ```java
   if (toolchain == null ) { do with shared-utils } else { do with toolchain }

and when I look at implementation, I see that the tool name has ".exe" added before using toolchain, but it should not: I really fear the current code simply does not work

option 2, ie simply removing this toolchain support, looks to be the right solution to me

any objection?

[jira-importer]

Robert Scholte commented

In general I would say that any *-utils should never depend on maven core dependencies. I think currently toolchain support have been improved a lot, so no need to have it here. Kind of a shame we just moved to 3.x, because this is actually a major change.

[jira-importer]

Hervé Boutemy commented

I re-read the code: my analysis about .exe was simply wrong

I'll implement the reflection

[jira-importer]

Hervé Boutemy commented

while working on this, I found that when you remove maven-core as optional dependency, you find that plexus-container is used for logging

by extension from maven-core, which was optional, it is told optional: but the code does not check if logging is injected or not

really, is this code about java tool really used somewhere?
and is it used in a non Maven context, ie without plexus container?

I really find this feature strange in maven-shared-utils given its requirements