[MSHARED-285] Port tests to JUnit 4.11

[jira-importer]

tradej opened MSHARED-285 and commented

Hi. The new version of JUnit has slightly different method signatures that in some cases (such as yours) limit usage of existing tests - they are too broad, type-wise. To accomodate for the change, please, be so kind so as to include this patch that rectifies the problem. Thank you.

---

Affects: maven-shared-utils-0.4

Attachments:

• maven-shared-utils-tests.patch (1.14 kB)
• the-correct-patch.patch (3.93 kB)

[jira-importer]

Olivier Lamy commented

what is your patch exactly ?

[jira-importer]

tradej commented

Sorry, wrong patch. Attached the correct one.

[jira-importer]

Olivier Lamy commented

applying the patch cause compilation failure:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/PathToolTest.java:[146,31] cannot find symbol
symbol : method <java.lang.Object>nullValue()
location: class org.hamcrest.CoreMatchers
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java:[185,59] cannot find symbol
symbol : method <java.io.File>nullValue()
location: class org.hamcrest.CoreMatchers
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java:[186,93] cannot find symbol
symbol : method <java.io.File>nullValue()
location: class org.hamcrest.CoreMatchers

[jira-importer]

tradej commented

That is mighty weird, I can't replicate that problem. Can you please give me your entire mvn -X output, so I can compare?

[jira-importer]

Olivier Lamy commented

mb-olamy:maven-shared-utils olamy$ patch -p1 < the-correct-patch.patch
patching file pom.xml
patching file src/test/java/org/apache/maven/shared/utils/ExpandTest.java
patching file src/test/java/org/apache/maven/shared/utils/reflection/ReflectorTest.java
mb-olamy:maven-shared-utils olamy$ mvn clean install (-X will be too verbose)
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Maven Shared Utils 0.5-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ maven-shared-utils ---
[INFO] Deleting /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/target
[INFO]
[INFO] --- maven-remote-resources-plugin:1.4:process (default) @ maven-shared-utils ---
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ maven-shared-utils ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 0 resource
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.0:compile (default-compile) @ maven-shared-utils ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 55 source files to /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/target/classes
[WARNING] Note: /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/io/FileUtils.java uses or overrides a deprecated API.
[WARNING] Note: Recompile with -Xlint:deprecation for details.
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ maven-shared-utils ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 5 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.0:testCompile (default-testCompile) @ maven-shared-utils ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 27 source files to /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/target/test-classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING :
[INFO] -------------------------------------------------------------
[WARNING] Note: Some input files use or override a deprecated API.
[WARNING] Note: Recompile with -Xlint:deprecation for details.
[WARNING] Note: /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/cli/shell/BourneShellTest.java uses unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 4 warnings
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/PathToolTest.java:[146,31] cannot find symbol
symbol : method <java.lang.Object>nullValue()
location: class org.hamcrest.CoreMatchers
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java:[185,59] cannot find symbol
symbol : method <java.io.File>nullValue()
location: class org.hamcrest.CoreMatchers
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java:[186,93] cannot find symbol
symbol : method <java.io.File>nullValue()
location: class org.hamcrest.CoreMatchers
[INFO] 3 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.172s
[INFO] Finished at: Mon May 06 20:44:44 EST 2013
[INFO] Final Memory: 16M/758M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.0:testCompile (default-testCompile) on project maven-shared-utils: Compilation failure: Compilation failure:
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/PathToolTest.java:[146,31] cannot find symbol
[ERROR] symbol : method <java.lang.Object>nullValue()
[ERROR] location: class org.hamcrest.CoreMatchers
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java:[185,59] cannot find symbol
[ERROR] symbol : method <java.io.File>nullValue()
[ERROR] location: class org.hamcrest.CoreMatchers
[ERROR] /Users/olamy/dev/sources/maven/maven-shared/maven-shared-utils/src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java:[186,93] cannot find symbol
[ERROR] symbol : method <java.io.File>nullValue()
[ERROR] location: class org.hamcrest.CoreMatchers
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Note I use jdk 1.6 (sure it work fine with 1.7 :-) )

[jira-importer]

Olivier Lamy commented

patch applied with modification to get it working with at least 1.6

[jira-importer]

Kristian Rosenvold commented

1.6 ??

[jira-importer]

Olivier Lamy commented

1.5 too :-)