ArtifactLocatorStrategy: ArtifactNotFoundException catch block is dead code

[elharo]

Bug #10

ArtifactLocatorStrategy.java lines 161-168

ArtifactNotFoundException extends ArtifactResolutionException in the Maven artifact API, so the catch (ArtifactNotFoundException e) block at lines 165-168 is never reached — the preceding catch (ArtifactResolutionException e) at lines 161-164 catches all instances. This makes the second catch block dead code.

[dhritimanchakra]

Hi Could you kindly assign this to me i would really like to work in this i am forking it and working on the issue

[elharo]

Bugs are not assigned to new contributors. Just send a PR.

[elharo]

This is not a bug. ArtifactResolutionException and ArtifactNotFoundException are sibling classes — both extend AbstractArtifactResolutionException directly. Neither extends the other.

AbstractArtifactResolutionException
  ├── ArtifactResolutionException
  └── ArtifactNotFoundException

Both catch blocks in ArtifactLocatorStrategy.java:161-168 are reachable. An ArtifactNotFoundException will not be caught by the ArtifactResolutionException handler.