[MSHARED-392] AbstractMavenReportRenderer#applyPattern(String) chokes on some specific input and produces useless segments

[jira-importer]

Michael Osipov opened MSHARED-392 and commented

Consider this input:

{Indiana University Extreme! Lab Software License, vesion 1.1.1,http://www.extreme.indiana.edu/viewcvs/~checkout~/XPP3/java/LICENSE.txt}{Public Domain,http://creativecommons.org/licenses/publicdomain}{Apache Software License, version 1.1,http://www.apache.org/licenses/LICENSE-1.1}

It should be broken up into six segments. The output of applyPattern is:

[0]	"Indiana University Extreme! Lab Software License, vesion 1.1.1" (id=321)
[1]	"http://www.extreme.indiana.edu/viewcvs/~checkout~/XPP3/java/LICENSE.txt" (id=322)
[2]	"" (id=323)
[3]	null
[4]	"Public Domain" (id=324)
[5]	"http://creativecommons.org/licenses/publicdomain" (id=325)
[6]	"" (id=326)
[7]	null
[8]	"Apache Software License, version 1.1" (id=328)
[9]	"http://www.apache.org/licenses/LICENSE-1.1" (id=329)

and the output is incorrectly generated.

---

Affects: maven-reporting-impl-2.3

[jira-importer]

Hervé Boutemy commented

yes, since coma "," is the separator between label and url, and no escaping mecanism is available, you can't use a label with coma in it

[jira-importer]

Robert Scholte commented

Fixed in r1693466.
Root cause: wrong calculation of offset when there are 2 or more links in 1 line.