Skip to content

[MSHARED-1029] Drop support for maven below 3.2.x - #8

Merged
cstamas merged 9 commits into
masterfrom
support-mvn-32x-above
Jan 25, 2022
Merged

[MSHARED-1029] Drop support for maven below 3.2.x#8
cstamas merged 9 commits into
masterfrom
support-mvn-32x-above

Conversation

@cstamas

@cstamas cstamas commented Jan 24, 2022

Copy link
Copy Markdown
Member

@cstamas cstamas self-assigned this Jan 24, 2022
Comment thread pom.xml
Comment thread pom.xml Outdated
Comment thread src/test/java/org/apache/maven/reporting/exec/TestDefaultMavenReportExecutor.java Outdated
@michael-o
michael-o self-requested a review January 24, 2022 16:01

@michael-o michael-o left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, through create a JIRA issue for this.

Comment thread pom.xml
Comment thread pom.xml
@cstamas cstamas changed the title Drop support for maven below 3.2.x [MSHARED-1029] Drop support for maven below 3.2.x Jan 25, 2022
Ideally I'd just DISABLE addition of dependency links,
but that seems impossible.
@cstamas

cstamas commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

@slawekjaranowski why are some checks skipped (they look like interpolation failed on them?)

@cstamas

cstamas commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

Also, this PR passes on me locally and also on Jenkins https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-exec/job/support-mvn-32x-above/ so something is funky here

@michael-o

Copy link
Copy Markdown
Member

Squash and merge that shit!

@cstamas
cstamas merged commit 526dbc3 into master Jan 25, 2022
@cstamas
cstamas deleted the support-mvn-32x-above branch January 25, 2022 12:26
@jira-importer

Copy link
Copy Markdown

Resolve #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants