[MSHARED-335] Remove redundant executionId from reports

[jira-importer]

Michael Osipov opened MSHARED-335 and commented

Currently, following is constructed:

MojoExecution mojoExecution = new MojoExecution( plugin, report.getGoal(), "report:" + report.getGoal() );

The output looks like this:

[INFO] >>> maven-javadoc-plugin:2.9.1:javadoc (report:javadoc) > generate-sources @ apache-maven >>>

report: is always static and :javadoc is duplicated. So, the executionId contains fixed and redundant information. Remove them and make the entire line concise.

The output shall be:

[INFO] >>> maven-javadoc-plugin:2.9.1:javadoc > generate-sources @ apache-maven >>>

This was discovered with MNG-5630.

---

Affects: maven-reporting-exec-1.2

Issue Links:

• MSITE-720 upgrade maven-reporting-exec to 1.2

• MNG-5630 improve display of forked executions

[jira-importer]

Hervé Boutemy commented

mojo execution id can't be removed: we can choose another value, but not remove it

notice I don't really get how it is used (apart from this display)

[jira-importer]

Michael Osipov commented

Why can't it be removed? MojoExecution has constructors where executionId is set to null.

[jira-importer]

Hervé Boutemy commented

you're right: I didn't check that this value was supported (and would not display anything)

seems a good idea, since this default execution id doesn't seem to have any interest, it's better to completely remove it

[jira-importer]

Hervé Boutemy commented

done in r1595450

[jira-importer]

Michael Osipov commented

Are you able to provide real life output?

[jira-importer]

Hervé Boutemy commented

the component has a "forked-lifecycle" IT to check

here is an extract, build with Maven 3.2.2-SNAPSHOT (for MNG-5630)

[INFO] >>> maven-javadoc-plugin:2.9.1:javadoc > generate-sources @ forked-lifecycle >>>
[INFO] 
[INFO] <<< maven-javadoc-plugin:2.9.1:javadoc < generate-sources @ forked-lifecycle <<<

[jira-importer]

Michael Osipov commented

Thanks, great improvement.