[MSHARED-266] run aggregator reports only when current projet is pom packaging and has modules

[jira-importer]

Hervé Boutemy opened MSHARED-266 and commented

would fix MSITE-454

simply adding a plugin to reporting section, without defining any reportSets, will avoid running aggregate reports in every module

notice: this will work only with Maven 3, since Maven 2 runs reports from core and not from m-site-p/m-reporting-exec

---

Affects: maven-reporting-exec-1.0.2

Issue Links:

• MJAVADOC-171 Modules in multi-module projects are "built" too often

• MSITE-720 upgrade maven-reporting-exec to 1.2

• MSITE-454 Don't use aggregator mojos for default report set
  ("is depended upon by")

1 votes, 3 watchers

[jira-importer]

Hervé Boutemy commented

fixed in r1593762

the solution is not exactly what was expected when creating the issue: in fact, lifecycle was always forked and report was executed only when canGenerateReport() was true

now lifecycle will be forked only when canGenerateReport() is true: this will reduce the count of forked lifecycles, the key algorithm will be in canGenerateReport() method in every reporting plugin/mojo

[jira-importer]

Anthony Whitford commented

Please accept my sincere appreciation for investigating this; this should positively impact build times. (y)

[jira-importer]

Hervé Boutemy commented

glad to know you appreciate :)
it was frustrating not to understand

[jira-importer]

Hervé Boutemy commented

the change makes maven-site-plugin "full-reporting" IT fail, because cobertura report isn't generated
looking at build.log:

[INFO] Not executing cobertura:report as the cobertura data file (/home/herve/projets/maven/trunks/plugins/maven-site-plugin/target/it/full-reporting/target/cobertura/cobertura.ser) could not be found

in the case of cobertura, the lifecycle forking requires to be executed before testing canGenerateReport() since the forked execution result affects the result

this is not the same expectations than m-javadoc-p

I fear I need to revert... :(

[jira-importer]

Hervé Boutemy commented

change reverted and replaced by initial idea in r1595568, ie for reports automatically added (only plugin is specified but not reports), don't add aggregator reports if not at execution root and in an aggregator pom

notice that this affects a little bit results for MJAVADOC-711: generate-sources phase is executed a little more, but at least, this doesn't break existing plugins