From 09279d98566b184f43886dcfcab2e5816d545cef Mon Sep 17 00:00:00 2001 From: Sebastian Tiemann Date: Tue, 23 Jun 2026 11:26:38 +0200 Subject: [PATCH] Remove attach / deployment feature --- src/it/buildinfo-mono/verify.groovy | 23 +------------- src/it/buildinfo-multi/verify.groovy | 29 +---------------- .../verify.groovy | 31 +------------------ .../artifact/buildinfo/BuildinfoMojo.java | 8 +---- 4 files changed, 4 insertions(+), 87 deletions(-) diff --git a/src/it/buildinfo-mono/verify.groovy b/src/it/buildinfo-mono/verify.groovy index fa4cc1e..a2660b1 100644 --- a/src/it/buildinfo-mono/verify.groovy +++ b/src/it/buildinfo-mono/verify.groovy @@ -37,25 +37,4 @@ if (mavenVersion.startsWith('4.')) { } assert buildinfo.contains( "mvn.minimum.version=3.0.5" ) -assert buildinfo.contains( "mvn.rebuild-args=-Dmaven.session.versionFilter=e(org.slf4j:slf4j-api:(1.7.36,))" ) - -// check existence of buildinfo in local repository -File local = new File( basedir, "../../local-repo/org/apache/maven/plugins/it/mono/1.0-SNAPSHOT/mono-1.0-SNAPSHOT.buildinfo") -assert local.isFile() - -// check existence of buildinfo in remote repository -File remoteDir = new File( basedir, "target/remote-repo/org/apache/maven/plugins/it/mono/1.0-SNAPSHOT") -assert remoteDir.isDirectory() - -int count = 0; -for ( File f : remoteDir.listFiles() ) { - // In Maven 4 there is the build-POM and also the new (but with old name) consumer-POM - // The expected ".buildinfo" file is named as the consumer-POM - if ( f.getName().endsWith( ".pom" ) && !f.getName().endsWith( "build.pom" )) { - File b = new File( remoteDir, f.getName().replace( ".pom", ".buildinfo" ) ) - println b - assert b.isFile() - count++ - } -} -assert count > 0 +assert buildinfo.contains( "mvn.rebuild-args=-Dmaven.session.versionFilter=e(org.slf4j:slf4j-api:(1.7.36,))" ) \ No newline at end of file diff --git a/src/it/buildinfo-multi/verify.groovy b/src/it/buildinfo-multi/verify.groovy index f457ed1..0807e03 100644 --- a/src/it/buildinfo-multi/verify.groovy +++ b/src/it/buildinfo-multi/verify.groovy @@ -114,31 +114,4 @@ if (mavenVersion.startsWith('4.')) { } assert !buildinfo.contains( ".buildinfo" ) -assert buildinfo.contains( "mvn.aggregate.artifact-id=ignore-jar" ) - -// check existence of buildinfo in local repository -File localIgnoreJar = new File( basedir, "../../local-repo/org/apache/maven/plugins/it/ignore-jar/1.0-SNAPSHOT/ignore-jar-1.0-SNAPSHOT.buildinfo") -assert localIgnoreJar.isFile() - -// check existence of buildinfo in remote repository -File remoteDir = null -if (mavenVersion.startsWith('4.')) { - remoteDir = new File( basedir, "target/remote-repo/org/apache/maven/plugins/it/ignore-jar/1.0-SNAPSHOT" ) -} else { - remoteDir = new File( basedir, "ignore-jar/target/remote-repo/org/apache/maven/plugins/it/ignore-jar/1.0-SNAPSHOT" ) -} - -assert remoteDir.isDirectory() - -for ( File f : remoteDir.listFiles() ) { - // In Maven 4 there is the build-POM and also the new (but with old name) consumer-POM - // The expected ".buildinfo" file is named as the consumer-POM - if ( f.getName().endsWith( ".pom" ) && !f.getName().endsWith( "build.pom" )) { - File b = new File( remoteDir, f.getName().replace( ".pom", ".buildinfo" ) ) - println b - assert b.isFile() - return - } -} - -// issue: buildinfo not found \ No newline at end of file +assert buildinfo.contains( "mvn.aggregate.artifact-id=ignore-jar" ) \ No newline at end of file diff --git a/src/it/buildinfo-skip-install-deploy/verify.groovy b/src/it/buildinfo-skip-install-deploy/verify.groovy index 1bcb7c8..3a4548e 100644 --- a/src/it/buildinfo-skip-install-deploy/verify.groovy +++ b/src/it/buildinfo-skip-install-deploy/verify.groovy @@ -51,34 +51,5 @@ if (mavenVersion.startsWith('4.')) { assert buildinfo.contains( "outputs.2.1.filename=multi-modB-1.0-SNAPSHOT.jar" ) } - assert !buildinfo.contains( ".buildinfo" ) -assert !buildinfo.contains( "outputs.3" ) - -// check existence of buildinfo in local repository -File localModB = new File( basedir, "../../local-repo/org/apache/maven/plugins/it/multi-modB/1.0-SNAPSHOT/multi-modB-1.0-SNAPSHOT.buildinfo") -assert localModB.isFile() - -// check existence of buildinfo in remote repository -File remoteDir = null -if (mavenVersion.startsWith('4.')) { - remoteDir = new File( basedir, "target/remote-repo/org/apache/maven/plugins/it/multi-modB/1.0-SNAPSHOT" ) -} else { - remoteDir = new File( basedir, "modB/target/remote-repo/org/apache/maven/plugins/it/multi-modB/1.0-SNAPSHOT" ) -} - -assert remoteDir.isDirectory() - -// check if there is a .buildinfo for the first .pom file -for ( File f : remoteDir.listFiles() ) { - // In Maven 4 there is the build-POM and also the new (but with old name) consumer-POM - // The expected ".buildinfo" file is named as the consumer-POM - if ( f.getName().endsWith( ".pom" ) && !f.getName().endsWith( "build.pom" )) { - File b = new File( remoteDir, f.getName().replace( ".pom", ".buildinfo" ) ) - println b - assert b.isFile() - return - } -} - -// issue: buildinfo not found \ No newline at end of file +assert !buildinfo.contains( "outputs.3" ) \ No newline at end of file diff --git a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/BuildinfoMojo.java b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/BuildinfoMojo.java index acf4f68..1c635b5 100644 --- a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/BuildinfoMojo.java +++ b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/BuildinfoMojo.java @@ -65,12 +65,6 @@ public BuildinfoMojo( @Override public void execute(Map artifacts) throws MojoExecutionException { - // eventually attach - if (attach) { - getLog().info("Attaching buildinfo"); - projectHelper.attachArtifact(project, "buildinfo", buildinfoFile); - } else { - getLog().info("NOT adding buildinfo to the list of attached artifacts."); - } + // attach / deploy feature has been removed, see #216 } }