From 20919c7fb6176267b2d83f1984b216188a4b2c13 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 10 Jul 2026 12:53:08 -0400 Subject: [PATCH 1/2] Minor: Fix docs for JoinSet --- datafusion/common-runtime/src/join_set.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/datafusion/common-runtime/src/join_set.rs b/datafusion/common-runtime/src/join_set.rs index 1857a4111dbcb..009f499f31e8d 100644 --- a/datafusion/common-runtime/src/join_set.rs +++ b/datafusion/common-runtime/src/join_set.rs @@ -21,10 +21,13 @@ use std::task::{Context, Poll}; use tokio::runtime::Handle; use tokio::task::{AbortHandle, Id, JoinError, LocalSet}; -/// A wrapper around Tokio's JoinSet that forwards all API calls while optionally +/// A wrapper around [Tokio's `JoinSet`] that forwards all API calls while optionally /// instrumenting spawned tasks and blocking closures with custom tracing behavior. -/// If no tracer is injected via `trace_utils::set_tracer`, tasks and closures are executed +/// If no tracer is injected via [`set_join_set_tracer`]`, tasks and closures are executed /// without any instrumentation. +/// +/// [Tokio's `JoinSet`]: tokio::task::JoinSet +/// [`set_join_set_tracer`]: crate::trace_utils::set_join_set_tracer #[derive(Debug)] pub struct JoinSet { inner: tokio::task::JoinSet, From 051dd73ca00c434bb18ac3fb4e5ae65f45faea46 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 10 Jul 2026 15:36:36 -0400 Subject: [PATCH 2/2] Apply suggestion from @alamb --- datafusion/common-runtime/src/join_set.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/common-runtime/src/join_set.rs b/datafusion/common-runtime/src/join_set.rs index 009f499f31e8d..3ac5912243817 100644 --- a/datafusion/common-runtime/src/join_set.rs +++ b/datafusion/common-runtime/src/join_set.rs @@ -23,7 +23,7 @@ use tokio::task::{AbortHandle, Id, JoinError, LocalSet}; /// A wrapper around [Tokio's `JoinSet`] that forwards all API calls while optionally /// instrumenting spawned tasks and blocking closures with custom tracing behavior. -/// If no tracer is injected via [`set_join_set_tracer`]`, tasks and closures are executed +/// If no tracer is injected via [`set_join_set_tracer`], tasks and closures are executed /// without any instrumentation. /// /// [Tokio's `JoinSet`]: tokio::task::JoinSet