feat: add GroupColumn support for Duration in multi-column GROUP BY - #23783
Open
tohuya6 wants to merge 1 commit into
Open
feat: add GroupColumn support for Duration in multi-column GROUP BY#23783tohuya6 wants to merge 1 commit into
tohuya6 wants to merge 1 commit into
Conversation
…lumn GROUP BY `multi_group_by::group_column_supported_type` gates which GROUP BY columns can use the column-wise `GroupValuesColumn` fast path. Any unsupported column forces the entire grouping onto the byte-encoded `GroupValuesRows` fallback, so a single `Duration` key dragged an otherwise-qualifying multi-column GROUP BY onto the slow path. `Duration` shares the `i64` native representation of `Timestamp`, so it reuses the existing `PrimitiveGroupValueBuilder` with no new builder type: - dispatch the four `Duration*Type` units in `make_group_column` - accept `Duration(_)` in `group_column_supported_type` (all four units are valid Arrow types, unlike Time32/Time64) - extend the `group_column_supported_type` <-> `make_group_column` consistency fuzz with the four Duration units - add an end-to-end unit test (Duration GROUP BY dedups including nulls and preserves the Duration output type) and a Duration GROUP BY block (single- and multi-column keys) in aggregate.slt - add a `(Duration, Int32)` group-count benchmark to `benches/multi_group_by.rs` Part of apache#22715
github-actions
Bot
added
sqllogictest
7 tasks
kosiew
approved these changes
Jul 28, 2026
| fn test_group_values_column_duration() { | ||
| use arrow::datatypes::TimeUnit; | ||
|
|
||
| let schema = Arc::new(Schema::new(vec
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23783 +/- ##
==========================================
- Coverage 80.71% 80.71% -0.01%
==========================================
Files 1089 1089
Lines 368760 368798 +38
Branches 368760 368798 +38
==========================================
+ Hits 297647 297667 +20
- Misses 53372 53382 +10
- Partials 17741 17749 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
multi_group_by::group_column_supported_typegates which GROUP BY columns mayuse the column-wise
GroupValuesColumnfast path, and the gate isall-or-nothing: a single unsupported column forces the entire grouping onto
the byte-encoded
GroupValuesRowsfallback, even when every other key columnwould have qualified. A
Durationkey triggers exactly that today, so anotherwise-qualifying multi-column
GROUP BYpays the row-encoding tax because ofone column.
Durationshares thei64native representation already used byTimestamp,so supporting it is a pure slot-in of the existing
PrimitiveGroupValueBuilder—no new builder type and no new comparison/hash logic.
What changes are included in this PR?
Duration(_)ingroup_column_supported_type(all fourTimeUnits arevalid Arrow types, unlike the restricted
Time32/Time64set).Duration*Typeunits inmake_group_column.group_column_supported_type↔make_group_columnconsistency fuzzwith all four Duration units.
(Duration, Int32)group-count benchmark tobenches/multi_group_by.rs.Are these changes tested?
Yes.
test_group_values_column_duration: aDurationkey stays on theGroupValuesColumnpath, dedups equal durations (including nulls), andround-trips with the
Durationoutput type preserved (not the barei64).Durationunit routes through thedispatcher.
DurationGROUP BYcoverage inaggregate.slt.Are there any user-facing changes?
No API changes.
GROUP BYqueries with aDurationkey now use the column-wisefast path instead of the row-encoded fallback; results are unchanged.