Add deprecation markers and fixes for CI.

Author: JSOD11

datafusion/core/tests/fuzz_cases/once_exec.rs

@@ -97,7 +97,7 @@ impl ExecutionPlan for OnceExec {
     fn with_new_children(
         self: Arc<Self>,
         children: Vec<Arc<dyn ExecutionPlan>>,
-    ) -> datafusion_common::Result<Arc<dyn ExecutionPlan>> {
+    ) -> Result<Arc<dyn ExecutionPlan>> {
         self.replace_children(children, ChildrenPropertiesHint::Recompute)
     }
 
@@ -106,7 +106,7 @@ impl ExecutionPlan for OnceExec {
         &self,
         partition: usize,
         _context: Arc<TaskContext>,
-    ) -> datafusion_common::Result<SendableRecordBatchStream> {
+    ) -> Result<SendableRecordBatchStream> {
         assert_eq!(partition, 0);
 
         let stream = self.stream.lock().unwrap().take();

datafusion/physical-plan/src/display.rs

@@ -1578,10 +1578,10 @@ mod tests {
         use insta::assert_snapshot;
 
         use super::super::DisplayableExecutionPlan;
-        use crate::ChildrenPropertiesHint;
         use crate::empty::EmptyExec;
         use crate::filter::FilterExec;
         use crate::projection::ProjectionExec;
+        use crate::{ChildrenPropertiesHint, ExecutionPlan};
         use datafusion_physical_expr::expressions::{binary, col, lit};
         use datafusion_physical_expr::{Partitioning, PhysicalExpr};
 

datafusion/physical-plan/src/execution_plan.rs

@@ -249,6 +249,7 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send + Sync {
 
     /// Returns a clone of the existing plan with the children replaced, skipping
     /// recomputation of plan properties if possible as indicated by the hint.
+    #[expect(deprecated)]
     fn replace_children(
         self: Arc<Self>,
         children: Vec<Arc<dyn ExecutionPlan>>,
@@ -264,6 +265,10 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send + Sync {
 
     /// Returns a new `ExecutionPlan` where all existing children were replaced
     /// by the `children`, in order
+    #[deprecated(
+        since = "55.0.0",
+        note = "Use `ExecutionPlan::replace_children` with ChildrenPropertiesHint::Recompute"
+    )]
     fn with_new_children(
         self: Arc<Self>,
         children: Vec<Arc<dyn ExecutionPlan>>,
@@ -283,6 +288,11 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send + Sync {
     ///
     /// Callers should route through [`with_new_children_if_necessary`] and
     /// not invoke this method directly.
+    #[deprecated(
+        since = "55.0.0",
+        note = "Use `ExecutionPlan::replace_children` with ChildrenPropertiesHint::SameProperties"
+    )]
+    #[expect(deprecated)]
     fn with_new_children_and_same_properties(
         self: Arc<Self>,
         children: Vec<Arc<dyn ExecutionPlan>>,