Skip to content

Commit c195869

Browse files
committed
test(agg): drop brittle memory-delta assert on mixed-schema path
Addresses @kosiew's review on #23523. The assert `column_size < rows_size` couples this correctness test to Arrow's Row memory accounting; the printed comparison stays for reviewer visibility. Memory delta is more appropriately tracked via benchmarks.
1 parent 0ab09b7 commit c195869

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

  • datafusion/physical-plan/src/aggregates/group_values/multi_group_by

datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1367,8 +1367,13 @@ mod tests {
13671367
assert_eq!(g1, g2, "group assignment must match the rows fallback");
13681368

13691369
// (b) Memory: the column-wise path stores the 8 native columns compactly
1370-
// and only row-encodes the nested one, so it must be smaller than
1370+
// and only row-encodes the nested one, so it should be smaller than
13711371
// encoding every column into rows.
1372+
//
1373+
// The delta is only printed here — a hard `column_size < rows_size`
1374+
// assert would be brittle to future Arrow row-format or memory-
1375+
// accounting changes without reflecting a grouping-correctness
1376+
// regression. Track the memory improvement via benchmarks instead.
13721377
let column_size = column_path.size();
13731378
let rows_size = rows_path.size();
13741379
println!(
@@ -1377,11 +1382,6 @@ mod tests {
13771382
({:.1}% of fallback)",
13781383
100.0 * column_size as f64 / rows_size as f64
13791384
);
1380-
assert!(
1381-
column_size < rows_size,
1382-
"expected column-wise path ({column_size}) to use less memory than \
1383-
the all-rows fallback ({rows_size})"
1384-
);
13851385

13861386
// Emitted values must be equal too (compare via the rows fallback which
13871387
// is the established reference implementation).

0 commit comments

Comments
 (0)