Skip to content

Commit b72e6c0

Browse files
adriangbclaude
andcommitted
refactor(proto): keep the datasource proto module private
The module holds nothing but `TryFrom` impls, and trait impls are registered globally by coherence, so they reach every downstream crate whether or not the module that writes them is reachable by path. `pub` therefore adds no capability: it only publishes an item-less module page and a path we would then owe compatibility to. If a later conversion in this family needs a named helper that `TryFrom` cannot express (an encode/decode context, per #23494), exporting the module again is additive. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 8f9a8fe commit b72e6c0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • datafusion/datasource/src

datafusion/datasource/src/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pub mod projection;
4444
/// Protobuf conversions for [`FileRange`], [`PartitionedFile`] and
4545
/// [`FileGroup`](crate::file_groups::FileGroup), gated on the `proto` feature.
4646
#[cfg(feature = "proto")]
47-
pub mod proto;
47+
mod proto;
4848
pub mod schema_adapter;
4949
pub mod sink;
5050
pub mod source;

0 commit comments

Comments
 (0)