fix: stop timestamp series at range boundary

Author: u70b3

datafusion/functions-table/src/generate_series.rs

@@ -197,6 +197,27 @@ impl SeriesValue for TimestampValue {
         Ok(())
     }
 
+    fn advance_with_end(&mut self, end: &mut Self, step: &Self::StepType) -> Result<()> {
+        let tz = self
+            .parsed_tz
+            .unwrap_or_else(|| Tz::from_str("+00:00").unwrap());
+        if let Some(next_ts) =
+            TimestampNanosecondType::add_month_day_nano(self.value, *step, tz)
+        {
+            self.value = next_ts;
+        } else {
+            // Advancing would exceed the timestamp range. Clamp `end` so the
+            // series terminates after the current (last reachable) value.
+            let step_negative = step.months < 0 || step.days < 0 || step.nanoseconds < 0;
+            end.value = if step_negative {
+                self.value.saturating_add(1)
+            } else {
+                self.value.saturating_sub(1)
+            };
+        }
+        Ok(())
+    }
+
     fn create_array(&self, values: Vec<Self::ValueType>) -> Result<ArrayRef> {
         let array = TimestampNanosecondArray::from(values);
 

datafusion/sqllogictest/test_files/table_functions.slt

@@ -246,6 +246,19 @@ SELECT * FROM generate_series(TIMESTAMP '2262-04-11T23:47:16.854775807', TIMESTA
 ----
 2262-04-11T23:47:16.854775807
 
+# A timestamp step that exceeds the nanosecond range must terminate after the
+# last reachable value instead of returning an overflow error.
+query P
+SELECT * FROM generate_series(TIMESTAMP '2262-04-11T23:47:16.854775806', TIMESTAMP '2262-04-11T23:47:16.854775807', INTERVAL '2' NANOSECOND)
+----
+2262-04-11T23:47:16.854775806
+
+# Same behavior for date series, which use the timestamp implementation.
+query P
+SELECT * FROM generate_series(DATE '2262-04-10', DATE '2262-04-11', INTERVAL '2' DAY)
+----
+2262-04-10T00:00:00
+
 # UDF and UDTF `generate_series` can be used simultaneously
 query ? rowsort
 SELECT generate_series(1, t1.end) FROM generate_series(3, 5) as t1(end)