Skip to content

Commit a6d0291

Browse files
kumarUjjawaladriangb
authored andcommitted
Address FileScanConfig proto review feedback
1 parent c083115 commit a6d0291

3 files changed

Lines changed: 342 additions & 349 deletions

File tree

datafusion/datasource/src/file_scan_config/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ pub(crate) mod sort_pushdown;
2424
/// Attaches inherent `to_proto_conf` / `from_proto_conf` / `parse_table_schema_from_proto`
2525
/// helpers to [`FileScanConfig`] used by every file source's `try_to_proto` hook.
2626
#[cfg(feature = "proto")]
27-
mod proto;
27+
pub(crate) mod proto;
2828

2929
use crate::file_groups::FileGroup;
3030
use crate::{

datafusion/datasource/src/file_scan_config/proto.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,9 @@ fn file_group_from_proto(group: &protobuf::FileGroup) -> Result<FileGroup> {
456456
Ok(FileGroup::new(files))
457457
}
458458

459-
fn partitioned_file_to_proto(pf: &PartitionedFile) -> Result<protobuf::PartitionedFile> {
459+
pub(crate) fn partitioned_file_to_proto(
460+
pf: &PartitionedFile,
461+
) -> Result<protobuf::PartitionedFile> {
460462
let last_modified = pf.object_meta.last_modified;
461463
let last_modified_ns = last_modified.timestamp_nanos_opt().ok_or_else(|| {
462464
DataFusionError::Plan(format!(
@@ -485,7 +487,7 @@ fn partitioned_file_to_proto(pf: &PartitionedFile) -> Result<protobuf::Partition
485487
})
486488
}
487489

488-
fn partitioned_file_from_proto(
490+
pub(crate) fn partitioned_file_from_proto(
489491
val: &protobuf::PartitionedFile,
490492
) -> Result<PartitionedFile> {
491493
let mut pf = PartitionedFile::new_from_meta(ObjectMeta {

0 commit comments

Comments
 (0)