You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updated decimal SUM and AVG accumulators to use Decimal128Type::is_valid_decimal_precision from Arrow.
Removed imports that were only required by the duplicated implementation.
Why
Comet now depends on Arrow 58.4.0, which exposes the equivalent boolean precision-validation API. Keeping a local copy creates unnecessary duplication and risks the implementations diverging in the future.
The one CI failure here — PR Build (macOS) / macos-14/Spark 4.0, JDK 17, Scala 2.13 [scans] — is #5023, not a failure of this PR.
It's a JVM SIGSEGV at pc=0x0 (no test assertion failed anywhere in the log), and symbolizing the hs_err log from that job points at hdfsThreadDestructor: it calls (*env)->GetJavaVM on a stale JNIEnv, reads a null function entry, and branches to address zero. That's the long-standing HDFS-16021, still open upstream and still present in Hadoop trunk. It only reproduces on macOS because hdrs is enabled with vendored under [target.'cfg(target_os = "macos")'.dependencies], and ParquetReadFromFakeHadoopFsSuite deliberately routes fake:// through libhdfs (COMET_LIBHDFS_SCHEMES = "fake,hdfs").
That path is disjoint from this PR: the changes are three files under native/spark-expr/ (sum_decimal.rs, avg_decimal.rs, utils.rs), all decimal aggregation, with no scan/parquet/hdfs code touched. The Linux jobs and both Spark SQL test matrices are green.
Could a committer re-run that job? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5089
What changed
is_valid_decimal_precisionhelper.Decimal128Type::is_valid_decimal_precisionfrom Arrow.Why
Comet now depends on Arrow 58.4.0, which exposes the equivalent boolean precision-validation API. Keeping a local copy creates unnecessary duplication and risks the implementations diverging in the future.
Validation
cargo fmt --checkcargo clippy -p datafusion-comet-spark-expr --all-targets -- -D warningscargo test -p datafusion-comet-spark-exprCometCastSuiteCometExecSuite