From 65e0e2c37fb42a3c533009e2dfb43d27463b60f1 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 30 Apr 2026 09:52:45 -0400 Subject: [PATCH 1/2] Minor: document why FixedSizeBinary offset is always 0 --- arrow-array/src/array/fixed_size_binary_array.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arrow-array/src/array/fixed_size_binary_array.rs b/arrow-array/src/array/fixed_size_binary_array.rs index e8272be5d625..d4a900e31fa8 100644 --- a/arrow-array/src/array/fixed_size_binary_array.rs +++ b/arrow-array/src/array/fixed_size_binary_array.rs @@ -643,6 +643,8 @@ unsafe impl Array for FixedSizeBinaryArray { } fn offset(&self) -> usize { + // Slices are normalized by rebasing `value_data`/`nulls`, so this type + // does not retain a separate logical element offset. 0 } From 9e443a364818bf2fb9e2a2ff61834e172d3be1a5 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 30 Apr 2026 09:55:04 -0400 Subject: [PATCH 2/2] improve --- arrow-array/src/array/fixed_size_binary_array.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arrow-array/src/array/fixed_size_binary_array.rs b/arrow-array/src/array/fixed_size_binary_array.rs index d4a900e31fa8..39bfc1db4ad1 100644 --- a/arrow-array/src/array/fixed_size_binary_array.rs +++ b/arrow-array/src/array/fixed_size_binary_array.rs @@ -643,8 +643,8 @@ unsafe impl Array for FixedSizeBinaryArray { } fn offset(&self) -> usize { - // Slices are normalized by rebasing `value_data`/`nulls`, so this type - // does not retain a separate logical element offset. + // Slices are normalized by slicing `value_data`/`nulls` directly; + // FSB does not retain a separate logical element offset. 0 }