From 11d5c37f08772a87df199533414253feffad4a12 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Tue, 31 Mar 2026 16:27:44 -0400 Subject: [PATCH 1/2] Disable failing arrow_writer benchmark --- parquet/benches/arrow_writer.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/parquet/benches/arrow_writer.rs b/parquet/benches/arrow_writer.rs index 2381941897c7..d830c300c672 100644 --- a/parquet/benches/arrow_writer.rs +++ b/parquet/benches/arrow_writer.rs @@ -420,10 +420,13 @@ fn create_writer_props() -> Vec<(&'static str, WriterProperties)> { .build(); props.push(("zstd_parquet_2", prop)); + // Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed + /* let prop = WriterProperties::builder() .set_content_defined_chunking(Some(CdcOptions::default())) .build(); props.push(("cdc", prop)); + */ props } From bc08899eec508445039e41abe42e189ac10f4fc8 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Wed, 1 Apr 2026 08:22:55 -0400 Subject: [PATCH 2/2] Clippy and easier to undersgtand comments --- parquet/benches/arrow_writer.rs | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/parquet/benches/arrow_writer.rs b/parquet/benches/arrow_writer.rs index d830c300c672..0ee25873ab60 100644 --- a/parquet/benches/arrow_writer.rs +++ b/parquet/benches/arrow_writer.rs @@ -34,7 +34,7 @@ use arrow::util::bench_util::{create_f16_array, create_f32_array, create_f64_arr use arrow::{record_batch::RecordBatch, util::data_gen::*}; use arrow_array::RecordBatchOptions; use parquet::errors::Result; -use parquet::file::properties::{CdcOptions, WriterProperties, WriterVersion}; +use parquet::file::properties::{WriterProperties, WriterVersion}; fn create_primitive_bench_batch( size: usize, @@ -421,12 +421,11 @@ fn create_writer_props() -> Vec<(&'static str, WriterProperties)> { props.push(("zstd_parquet_2", prop)); // Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed - /* - let prop = WriterProperties::builder() - .set_content_defined_chunking(Some(CdcOptions::default())) - .build(); - props.push(("cdc", prop)); - */ + // + // let prop = WriterProperties::builder() + // .set_content_defined_chunking(Some(CdcOptions::default())) + // .build(); + // props.push(("cdc", prop)); props }