From 86379ba354ade908838c868318ea848a09da3207 Mon Sep 17 00:00:00 2001 From: Hashim1999164 Date: Wed, 29 Jul 2026 18:51:49 +0500 Subject: [PATCH 1/3] Enable allow_attributes lint for arrow-string --- arrow-string/src/binary_predicate.rs | 1 - arrow-string/src/lib.rs | 1 + arrow-string/src/predicate.rs | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arrow-string/src/binary_predicate.rs b/arrow-string/src/binary_predicate.rs index 590a34b10e27..b14e3c255997 100644 --- a/arrow-string/src/binary_predicate.rs +++ b/arrow-string/src/binary_predicate.rs @@ -21,7 +21,6 @@ use memchr::memmem::Finder; use std::iter::zip; /// A binary based predicate -#[allow(clippy::large_enum_variant)] pub enum BinaryPredicate<'a> { Contains(Finder<'a>), StartsWith(&'a [u8]), diff --git a/arrow-string/src/lib.rs b/arrow-string/src/lib.rs index 77c8e6050aa9..43ad45cf44ca 100644 --- a/arrow-string/src/lib.rs +++ b/arrow-string/src/lib.rs @@ -22,6 +22,7 @@ html_favicon_url = "https://arrow.apache.org/img/arrow-logo_chevrons_black-txt_transparent-bg.svg" )] #![cfg_attr(docsrs, feature(doc_cfg))] +#![deny(clippy::allow_attributes)] #![warn(missing_docs)] mod binary_like; diff --git a/arrow-string/src/predicate.rs b/arrow-string/src/predicate.rs index 8523129dbafd..d785c22b41db 100644 --- a/arrow-string/src/predicate.rs +++ b/arrow-string/src/predicate.rs @@ -24,7 +24,6 @@ use regex::{Regex, RegexBuilder}; use std::iter::zip; /// A string based predicate -#[allow(clippy::large_enum_variant)] pub(crate) enum Predicate<'a> { Eq(&'a str), Contains(Finder<'a>), From 4ae3eb044d77cdf6cf59158a37c1748ea996ada8 Mon Sep 17 00:00:00 2001 From: Hashim Khan Date: Wed, 29 Jul 2026 19:45:24 +0500 Subject: [PATCH 2/3] Use target-specific Clippy expectations --- arrow-string/src/binary_predicate.rs | 4 ++++ arrow-string/src/predicate.rs | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/arrow-string/src/binary_predicate.rs b/arrow-string/src/binary_predicate.rs index b14e3c255997..837efbbd7c47 100644 --- a/arrow-string/src/binary_predicate.rs +++ b/arrow-string/src/binary_predicate.rs @@ -21,6 +21,10 @@ use memchr::memmem::Finder; use std::iter::zip; /// A binary based predicate +#[cfg_attr( + all(target_os = "linux", target_arch = "x86_64"), + expect(clippy::large_enum_variant) +)] pub enum BinaryPredicate<'a> { Contains(Finder<'a>), StartsWith(&'a [u8]), diff --git a/arrow-string/src/predicate.rs b/arrow-string/src/predicate.rs index d785c22b41db..f3d3a8fbd02e 100644 --- a/arrow-string/src/predicate.rs +++ b/arrow-string/src/predicate.rs @@ -24,6 +24,10 @@ use regex::{Regex, RegexBuilder}; use std::iter::zip; /// A string based predicate +#[cfg_attr( + all(target_os = "linux", target_arch = "x86_64"), + expect(clippy::large_enum_variant) +)] pub(crate) enum Predicate<'a> { Eq(&'a str), Contains(Finder<'a>), From 70fb355aae0623312d993c96810ef36638679798 Mon Sep 17 00:00:00 2001 From: Hashim Khan Date: Fri, 31 Jul 2026 23:57:10 +0500 Subject: [PATCH 3/3] Use x86_64-wide Clippy expectation for large enum variants Apply the expectation on all x86_64 targets, not only Linux, so Windows x86_64 gets the same Clippy handling. --- arrow-string/src/binary_predicate.rs | 2 +- arrow-string/src/predicate.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arrow-string/src/binary_predicate.rs b/arrow-string/src/binary_predicate.rs index 837efbbd7c47..ea172b8acec1 100644 --- a/arrow-string/src/binary_predicate.rs +++ b/arrow-string/src/binary_predicate.rs @@ -22,7 +22,7 @@ use std::iter::zip; /// A binary based predicate #[cfg_attr( - all(target_os = "linux", target_arch = "x86_64"), + target_arch = "x86_64", expect(clippy::large_enum_variant) )] pub enum BinaryPredicate<'a> { diff --git a/arrow-string/src/predicate.rs b/arrow-string/src/predicate.rs index f3d3a8fbd02e..fe4d43112807 100644 --- a/arrow-string/src/predicate.rs +++ b/arrow-string/src/predicate.rs @@ -25,7 +25,7 @@ use std::iter::zip; /// A string based predicate #[cfg_attr( - all(target_os = "linux", target_arch = "x86_64"), + target_arch = "x86_64", expect(clippy::large_enum_variant) )] pub(crate) enum Predicate<'a> {