From 656a6e77fbeb6b084f1ffaab6c9d31d5a46b3c7a Mon Sep 17 00:00:00 2001 From: itsjunetime Date: Sun, 12 Jul 2026 21:49:01 -0500 Subject: [PATCH 1/2] Remove always-panicking benchmarks --- arrow/benches/concatenate_elements.rs | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/arrow/benches/concatenate_elements.rs b/arrow/benches/concatenate_elements.rs index 0b197a54ceae..459724635b8b 100644 --- a/arrow/benches/concatenate_elements.rs +++ b/arrow/benches/concatenate_elements.rs @@ -70,22 +70,6 @@ fn add_benchmark(c: &mut Criterion) { c.bench_function(&id, |b| b.iter(|| bench_concat(&array, &array))); } } - - let v1 = create_string_array_with_len::(10, 0.0, 20); - let v1 = create_dict_from_values::(1024, 0.0, &v1); - let v2 = create_string_array_with_len::(10, 0.0, 20); - let v2 = create_dict_from_values::(1024, 0.0, &v2); - c.bench_function("concat str_dict 1024", |b| { - b.iter(|| bench_concat(&v1, &v2)) - }); - - let v1 = create_string_array_with_len::(1024, 0.0, 20); - let v1 = create_sparse_dict_from_values::(1024, 0.0, &v1, 10..20); - let v2 = create_string_array_with_len::(1024, 0.0, 20); - let v2 = create_sparse_dict_from_values::(1024, 0.0, &v2, 30..40); - c.bench_function("concat str_dict_sparse 1024", |b| { - b.iter(|| bench_concat(&v1, &v2)) - }); } criterion_group!(benches, add_benchmark); From 3cee113c81e778835f780746d35d68bab632c7e9 Mon Sep 17 00:00:00 2001 From: itsjunetime Date: Sun, 19 Jul 2026 14:53:09 -0500 Subject: [PATCH 2/2] Remove unused import --- arrow/benches/concatenate_elements.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/arrow/benches/concatenate_elements.rs b/arrow/benches/concatenate_elements.rs index 459724635b8b..2e841eb031a1 100644 --- a/arrow/benches/concatenate_elements.rs +++ b/arrow/benches/concatenate_elements.rs @@ -22,7 +22,6 @@ extern crate criterion; use criterion::Criterion; use arrow::array::*; -use arrow::datatypes::*; use arrow::util::bench_util::*; use arrow_string::concat_elements::concat_elements_dyn; use std::hint;