Fix multiple item types list snippet#925
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request refactors a LazyColumn implementation to correctly handle multiple item types by removing an erroneous internal loop and utilizing the item index. It also updates the contentType parameter to use the message class for better performance. A review comment identifies the use of org.w3c.dom.Text as inappropriate for Android development and suggests refactoring to use a String or a custom data class.
64e92fa to
c2f3566
Compare
This corrects the multiple item types snippet used by the Compose quick guide.
Test: ANDROID_HOME=/Users/Dheeraj/Library/Android/sdk ./gradlew :compose:snippets:compileDebugKotlin