Editing files should not be possible while running simulation

[andeplane]

This is really to avoid updated files from LAMMPS simulation and editor disagreeing on what is latest content

[andeplane]

@cursoragent can you take a look here please?

[cursor]

Create PR

Excellent! I've reviewed the PR and implemented the feature to prevent file editing while a simulation is running. Here's what I found and fixed:

Summary

Problem: The PR aimed to prevent file editing during simulation runs to avoid conflicts between LAMMPS file updates and editor changes, but the implementation was missing.

Solution Implemented:

1. Modified Edit.tsx to:

   • Read the simulation's running state from the store
   • Set Monaco editor to readOnly mode when simulation is running
   • Display a clear notification banner informing users why editing is disabled
   • Adjust editor height to accommodate the notification banner

2. Created comprehensive tests in Edit.test.tsx covering:

   • Editor renders correctly when file is selected
   • Shows "No file selected" message appropriately
   • Editor is editable when simulation is not running
   • Editor is read-only when simulation is running
   • Notification banner appears/disappears based on simulation state
   • Content updates work correctly

Test Results:

• All 7 new Edit component tests passing ✓
• All 160 total tests passing ✓
• No linter errors ✓

The implementation properly prevents users from editing files during simulation runs, which protects against conflicts between LAMMPS updates and user edits. The visual feedback (orange notification banner) makes it clear to users why editing is disabled.

---

 

_{Learn more about Cursor Agents}