You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After extracting the common Data1D processing logic (see issue #185), the three sync modifiers need to be refactored to use the shared function, keeping only their unique logic.
Current Behavior
Each sync modifier (synccomputesmodifier.ts, syncfixesmodifier.ts, syncvariablesmodifier.ts) contains ~125 lines, with most of it being duplicated Data1D processing logic.
Expected Behavior
Refactor all three modifiers to:
Call the shared processData1D() helper function
Keep only the unique logic:
Which sync method to call (syncComputes(), syncFixes(), syncVariables())
Which name array to get (getComputeNames(), getFixNames(), getVariableNames())
Which collection to update in output (output.computes, output.fixes, output.variables)
Problem
After extracting the common Data1D processing logic (see issue #185), the three sync modifiers need to be refactored to use the shared function, keeping only their unique logic.
Current Behavior
Each sync modifier (
synccomputesmodifier.ts,syncfixesmodifier.ts,syncvariablesmodifier.ts) contains ~125 lines, with most of it being duplicated Data1D processing logic.Expected Behavior
Refactor all three modifiers to:
processData1D()helper functionsyncComputes(),syncFixes(),syncVariables())getComputeNames(),getFixNames(),getVariableNames())output.computes,output.fixes,output.variables)Files to Modify
src/modifiers/synccomputesmodifier.tssrc/modifiers/syncfixesmodifier.tssrc/modifiers/syncvariablesmodifier.tsPrerequisites
Benefits
Implementation Notes
Each modifier should:
syncComputes,syncFixes, orsyncVariables)processData1D()function for Data1D processing