Skip to content

ci(translation-sync): remove redundant push trigger #459

Description

@lizhengfeng101

Description

The translation-sync workflow (.github/workflows/translation-sync.yml) currently triggers on both push and pull_request events. Since all code merges into main via pull requests, the pull_request trigger already validates translation sync before merge — running the same check again on the resulting push to main is redundant and wastes CI resources.

Current trigger configuration (lines 9–19):

on:
  push:
    paths:
      - "README*.md"
      - "pages/src/content/docs/**"
      - "scripts/github-actions/check-translation-sync.*"
  pull_request:
    paths:
      - "README*.md"
      - "pages/src/content/docs/**"
      - "scripts/github-actions/check-translation-sync.*"

Scope

  • File: .github/workflows/translation-sync.yml
  • Area: CI workflow triggers
  • Remove the push: trigger block (lines 10–14), keeping only pull_request:

Acceptance Criteria

  • The on: section only contains a pull_request trigger with the existing paths: filter
  • The workflow no longer runs on push to main
  • All other workflow behavior (steps, container, env vars) remains unchanged

Context

Introduced in PR #455. The workflow validates README heading structure (blocking) and docs translation coverage (non-blocking). Since the non-blocking docs check uses github.event.pull_request.base.sha / head.sha, it is inherently PR-only anyway — the push trigger only exercises the blocking README check redundantly after merge.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions